From: Keith Owens <kaos@ocs.com.au>
To: Phil Brutsche <pbrutsch@tux.creighton.edu>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-kernel@vger.kernel.org, usb@in.tum.de
Subject: Re: [PATCH] 2.4.17 compile error + fix
Date: Sun, 23 Dec 2001 16:14:22 +1100 [thread overview]
Message-ID: <22287.1009084462@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "22 Dec 2001 22:28:56 MDT." <1009081736.968.0.camel@fury>
On 22 Dec 2001 22:28:56 -0600,
Phil Brutsche <pbrutsch@tux.creighton.edu> wrote:
>diff -urN linux/drivers/usb/usb-uhci.c
>linux-2.4.17-modified/drivers/usb/usb-uhci.c
>--- linux/drivers/usb/usb-uhci.c Fri Dec 21 11:41:55 2001
>+++ linux-2.4.17-modified/drivers/usb/usb-uhci.c Sat Dec 22
>22:10:27 2001
>@@ -3001,7 +3001,7 @@
> s->irq = irq;
>
> if(uhci_start_usb (s) < 0) {
>- uhci_pci_remove(dev);
>+ __devexit_p (uhci_pci_remove(dev));
> return -1;
> }
>
>The resulting kernel boots fine on a PII; there are no problems with
>hot-plugging USB devices.
>
>Marcelo, please consider for 2.4.18.
Do not apply, the code is wrong, uhci_pci_remove is called from
mainline code. If the mainline code is correct then uhci_pci_remove
must not be defined as __devexit/__devexit_p. If uhci_pci_remove is
not supposed to be called then the mainline code has to be changed. In
either case, it is a job for the uhci maintainer.
next prev parent reply other threads:[~2001-12-23 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-23 4:28 Phil Brutsche
2001-12-23 5:14 ` Keith Owens [this message]
2001-12-23 5:14 ` Andrew Morton
2001-12-23 19:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22287.1009084462@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=pbrutsch@tux.creighton.edu \
--cc=usb@in.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®