From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5024FC6FD1C for ; Mon, 20 Mar 2023 21:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbjCTVmf (ORCPT ); Mon, 20 Mar 2023 17:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjCTVmc (ORCPT ); Mon, 20 Mar 2023 17:42:32 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE3615576 for ; Mon, 20 Mar 2023 14:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1679348513; x=1710884513; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=bxVzq8suDNih9SH1Ok62kaz7FvxQWlE5bz197aYsbjU=; b=gbAtL/mKsYa22s5s1wyzIuqh5Lz6ww8OnLpfZSzhW1c6W9RBwnt0UhU5 dnwwtjsPdZ6MmR8TRTcy1JbBkRUNWcJUaxLy7EkKE81u4zekbYV0+rJll kdWr9/M+D1TC1m4JPtJKvYHDCh3iJzW/YTfLUH1TIyUVAwfrpVm1GEM09 TaRZKVCMuWBFzLbJguamR/SO/7cJbqi2WAY29ItWyJq60Nv2e826PqDTU IEpMM5S4pa+WJFL+xq5hxEPvnC0bkpbbxpZlvF0vtFvB+tP/L7Ml9R7gN jSPSVMJpKmfYZxM8AX4JLz1hI0rtKcxNkEn/Bm4hzBY5SbK7Vs5aTSeqE A==; X-IronPort-AV: E=Sophos;i="5.98,276,1673884800"; d="scan'208";a="231047317" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 21 Mar 2023 05:39:07 +0800 IronPort-SDR: Agcg18wCFLEkET/vOGMg4Pcl4KDYsg3Og3PJqGZ8Sa/tGIcSKsB5qRXUBJwTcd4fBeoWuHWtdE fpYLnz1JTJ9n2OFAkhZCETKXNEmLhFAvy/KJF0RQVBoIOoNCZVH5jxVvtGHX/thbFdWHNfD3is EXhPomqrMAUX/WFoldc9/2m1WzTUrEJEFyBhY8QM8LNgf5Ms3X8H78VokslMWen9ibL9DiZUfG 7mYZPd4SSsRS/MArdbpKPBj3Rm5sTuH7x5hXGMAEF0hfwDEueHjwIcCWXFEtvWt2WrCw6HNkzm 1GY= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Mar 2023 13:49:46 -0700 IronPort-SDR: mY/Dw1lhWx0/2Smqgt7nzwkdZqYQlnXeVd59TWsDs6nmorJtfsgyOndkU7jaq/FSSkdOH8XENh T5tk3QhvZz4qqVgPP1gRuAnJE1orgzHTIiMp2Ab+G/6OOu+qotgwk/2DeM9keNwxh9j8qPdNcs kYvoeYwpfYZrUWR7qaTFNB93vkPgv2OPI+W8XKZTE8JKBG7/UfqBbFOIkSReZ4HUdOR7NYN+f8 4EPNzaMwHnMR5f1wiut7NdAWWbltXwih1J5Y9X0btOZRR2uKvvaDaaNYv1ap4cPukX0l9hXVqg zoM= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Mar 2023 14:39:07 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4PgSmW0wDlz1RtVw for ; Mon, 20 Mar 2023 14:39:07 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1679348345; x=1681940346; bh=bxVzq8suDNih9SH1Ok62kaz7FvxQWlE5bz1 97aYsbjU=; b=EKxs8rpUot/qFRHAvND09IIAv6cqU/2Lev47PpifnoY6Vn42PvZ bLqMSLk5W+AyQuqTGKwodJfY4iDfhinl9cyIK7N2mtXEWEbGsMTiKxFf0DCuYwfv U7tD4WDxe1pbv3HNUfmVAdcHrTAMKvexZTU0GM1jYO4oNPGmPiD77lxKs2Zw8Hzb PwIdTneUr52J5sAiu9A7XMDGoEBHZesZf8Ek4BS/umk2gVFaA1nuC+gmt+D5Qto6 f5pqaIAayhxw2wlTZV+cAvKH6KJ3w/adruI7wi3ZwobRCy9apzq/Jd2TLBhGAwdK dxo6IBbJ/jukaj9W89Dx0kqPLMgyapwzAcw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7IOLsc0CEYsb for ; Mon, 20 Mar 2023 14:39:05 -0700 (PDT) Received: from [10.225.163.91] (unknown [10.225.163.91]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4PgSmM4CNrz1RtVm; Mon, 20 Mar 2023 14:38:59 -0700 (PDT) Message-ID: <2229e074-d78e-3bd5-bf06-a53e9ad57d02@opensource.wdc.com> Date: Tue, 21 Mar 2023 06:38:58 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RESEND,PATCH v2 01/10] kobject: introduce kobject_del_and_put() Content-Language: en-US To: Yangtao Li , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, jefflexu@linux.alibaba.com, jaegeuk@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org, konishi.ryusuke@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, richard@nod.at, djwong@kernel.org, naohiro.aota@wdc.com, jth@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20230320184657.56198-1-frank.li@vivo.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230320184657.56198-1-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/23 03:46, Yangtao Li wrote: > There are plenty of using kobject_del() and kobject_put() together > in the kernel tree. This patch wraps these two calls in a single helper. > > Signed-off-by: Yangtao Li > --- > v2: > -add kobject_del_and_put() users > resend patchset to gregkh, Rafael and Damien > include/linux/kobject.h | 1 + > lib/kobject.c | 17 +++++++++++++++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/include/linux/kobject.h b/include/linux/kobject.h > index bdab370a24f4..782d4bd119f8 100644 > --- a/include/linux/kobject.h > +++ b/include/linux/kobject.h > @@ -111,6 +111,7 @@ extern struct kobject *kobject_get(struct kobject *kobj); > extern struct kobject * __must_check kobject_get_unless_zero( > struct kobject *kobj); > extern void kobject_put(struct kobject *kobj); > +extern void kobject_del_and_put(struct kobject *kobj); > > extern const void *kobject_namespace(const struct kobject *kobj); > extern void kobject_get_ownership(const struct kobject *kobj, > diff --git a/lib/kobject.c b/lib/kobject.c > index 6e2f0bee3560..8c0293e37214 100644 > --- a/lib/kobject.c > +++ b/lib/kobject.c > @@ -731,6 +731,20 @@ void kobject_put(struct kobject *kobj) > } > EXPORT_SYMBOL(kobject_put); > > +/** > + * kobject_del_and_put() - Delete kobject. > + * @kobj: object. > + * > + * Unlink kobject from hierarchy and decrement the refcount. > + * If refcount is 0, call kobject_cleanup(). > + */ > +void kobject_del_and_put(struct kobject *kobj) > +{ > + kobject_del(kobj); > + kobject_put(kobj); > +} > +EXPORT_SYMBOL_GPL(kobject_del_and_put); Why not make this an inline helper defined in include/linux/kobject.h instead of a new symbol ? > + > static void dynamic_kobj_release(struct kobject *kobj) > { > pr_debug("kobject: (%p): %s\n", kobj, __func__); > @@ -874,8 +888,7 @@ void kset_unregister(struct kset *k) > { > if (!k) > return; > - kobject_del(&k->kobj); > - kobject_put(&k->kobj); > + kobject_del_and_put(&k->kobj); > } > EXPORT_SYMBOL(kset_unregister); > -- Damien Le Moal Western Digital Research