From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 365EB426ECC for ; Tue, 20 Jan 2026 12:07:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768910830; cv=none; b=GLtLbd2mTt+0OwJjj6csueIPM8EbMVckdvKTiMKCWPsK/heLYlk18/SUNe9bwx6XPxI2Hv2SAPGjB3/oIuLfUGng5CeIzTd/v6iwfAwQAmgEZTP0AaKBC8U2w8Y7Il2qwVa6R0Q7VZ5VNcYOPNozO68NESLBICqTSQNvL320hV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768910830; c=relaxed/simple; bh=6mJN4EWiKZWaSZItRX0vL+7HkWk5OupdgIHdp6FGDiU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WwYZ2flpS1IUMPsav69Yl//RlYyBDIOBHmHRSWU7/ALRKH0CidEtVJ1Rc8q6GzuVnikIIKSz0iC7hd9aGagynccm/yw3SZp1WSGYXmyR/KlFMoq1qwvROUpHC3ZvFSpUOud7RlyMtA3T4PWPvVCxMryUMTrPyafe+WgWYw7F6xE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YbRUp4rl; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YbRUp4rl" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-650854d9853so1010041a12.0 for ; Tue, 20 Jan 2026 04:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768910827; x=1769515627; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6mJN4EWiKZWaSZItRX0vL+7HkWk5OupdgIHdp6FGDiU=; b=YbRUp4rliEU76fFMjHfS0QiNwDj6fFXpDm65kwbgnOfVFuUUeT6eqZ03W5153nWVCz 79mV2QZCFjkHMRpSDLCIK45n4j5uHT+R63fv8WX+idxkFcyBPaFX4tPAd7LyaGesHxkX LDqYjPt7uGNcJg905UEhKla1lAvLE5/Vi+Y320QCuLaec8uliifbHsdNC97Ur5FQ+02T 9XL2ZZRD9kYsXdz5JhyM/Hbg6VJxjwl8aKqWu5LpZdCi+NCB8Qj8qx7pfWh/EOXEHERc 1XJ2bkStUPPlJQLcNgwncxEgttG5rUsvb8ky+DCTY6DW/+zd8oLUHNPg9VXHtFg+QOVW rtDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768910827; x=1769515627; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6mJN4EWiKZWaSZItRX0vL+7HkWk5OupdgIHdp6FGDiU=; b=OFpRxPKi9UbSARJXe7FRnzIYkvOiKRI7PZlKqBS1Pyn777R8f8CDv69uUnetSmT0dJ DB2nlgrnwVal/lEAoDJ1eBZXB/5q3QgsAAUPEI+0H7LQi967o8aOXfTvYAfGMlHRd/Bu FFgLuNC21+ldAtaoJxdomGwjDb/WzQmt3ZeObF5BTsnh0fjR+icp0kkix/gn7KAbM3mA RecPU+aKG7AC4VOp3WyyyoNmPp3J1iE626Wy1WiyhDiSgAcxwyYuZ26U4VG/F+Ttz/Zu JAalZImJ/pW331JuBzKYhR6hJmd/lbymDqZIvRdX0ImJ50iHQYzpEcG8r4GdmuCHDroP txRQ== X-Forwarded-Encrypted: i=1; AJvYcCVXXkkv10Pkr1IhUS302g4B+nhhrISKIUtqxNXGw1niajeF2mwuBdpF9K1ck8zEfyg09uyFKT9IKA2tBSE=@vger.kernel.org X-Gm-Message-State: AOJu0YyTu64bmLSWJD6pLNAN7wsZIzaqQ3H7wMBbkFuVjeL4uhx04Q/S 1q8pzhPHNiNpkHDsRGG7yfHmj3kJ9DhOruEP2IdkDxiYLHfmOcmAHzo/ X-Gm-Gg: AZuq6aK38jW24kptBq5pn15S7H8kzjCG4IbOJnuOF4UVMOsbAxJnvzzrM/uTNPEfmuS C0QhqcrHQkD0QuldFol/KnSpc/Kbw+b5ZbvaBEK+len0TjCb73yHBRWE4xeqh+ID3/k2dgpHbig 0m37MnF7JEClPhxZ7I2W3yNzAMmBGN1TYVkjC7jr5NN4q3nFh+egQ16DSF4nynb5va7Gc1L+JU3 sxcI3FPDEegZEt8CPK3+t42dkFLAhclvpEW7i7Y6LMV2on0XHJXnkXASqQQeHqQY4NDfDiVZEDe wfco3Cq9GC+K8OY+mCfo1yXMjOhrEIXVhyxyVVgNFxzFPEfhTpm/xuYz9nMF4Xh0LffGT1nw5fH QRE75qUKASpCQIxDJ4T14bKqpq3WnOMO5c8fCc34W340pBRO+5hF7mZi/fu0bVTIRA4C+Os3SYx GiE64YkmIU5Q9ajusdpS+2mHAql9aaJp1K70LuxkmejNRmIE1w7OFbLqlc5k5sjzOjcDVewM0= X-Received: by 2002:aa7:d74d:0:b0:658:dc6:6d08 with SMTP id 4fb4d7f45d1cf-6580dc6702dmr167598a12.7.1768910827175; Tue, 20 Jan 2026 04:07:07 -0800 (PST) Received: from [192.168.1.239] (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65452bce433sm13190978a12.3.2026.01.20.04.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 04:07:06 -0800 (PST) Message-ID: <222c4c14ee6c20f18381580b249d160d197ce3e4.camel@gmail.com> Subject: Re: [PATCH 01/17] drm/amd/display: Return if DisplayID not found in parse_amd_vsdb() From: Tomasz =?UTF-8?Q?Paku=C5=82a?= To: Jani Nikula , alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, siqueira@igalia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.berger@gmail.com Date: Tue, 20 Jan 2026 13:07:03 +0100 In-Reply-To: References: <20260119011146.62302-1-tomasz.pakula.oficjalny@gmail.com> <20260119011146.62302-2-tomasz.pakula.oficjalny@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 15:23 +0200, Jani Nikula wrote: > On Mon, 19 Jan 2026, Tomasz Paku=C5=82a wrote: > > [Why] > > The function would continue to try to parse EDID even if DisplayID > > extension block wasn't found. Sometimes it got lucky and found AMD vsdb > > in CEA extension block which made debugging harder. > >=20 > > [How] > > Add a return if DisplayID extension block wasn't found >=20 > Maybe don't use homegrown EDID parsing, but use drm_edid.c instead? >=20 > BR, > Jani. >=20 I would be all for it but I didn't want to make even more changes. I cannot refactor the whole amdgpu on my own :) Plus, the generic drm code doesn't yet parse AMD vsdb. I could certainly add such functionality, especially since it's already in projects like edid-decode but amdgpu seems to be doing a lot of home-grown edid parsing and I'm not really sure why, even sending stuff to firmware. Especially confusing is the part where AMD vsdb is parsed differently if it's in CTA extensiton block or DisplayID. They honestly are identical. At least, here in, setting the freesync caps, getting info from generic drm should be ok. I'll think about it and probably intoroduce AMD vsdb parsing to drm in a separate series. >=20 Tomasz