From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DFFC001DE for ; Tue, 15 Aug 2023 07:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235345AbjHOG7p (ORCPT ); Tue, 15 Aug 2023 02:59:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235340AbjHOG71 (ORCPT ); Tue, 15 Aug 2023 02:59:27 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1749E45; Mon, 14 Aug 2023 23:59:24 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37F6xEAg096903; Tue, 15 Aug 2023 01:59:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1692082754; bh=BMw0LM7FqJwhLGnw1m3bibtR1W6JwfqvbehtyyxAFh8=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=W1c3HsxvjIF7DygKdBPpQN4IiMUPtyua9yIsQYPI/0FTUNR8KOSUMQfvFFrSuf0z6 dIS9j6YY10H+QQAzxL9fxFD0CvV+5jhqBRWSpTbtOBJCQIQeVyDak+V/b52VVrbL/E omivWIAvD9Y2oQ0JL9m/QMsuaBwOfnsN0CXh6+vo= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37F6xEZO028641 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Aug 2023 01:59:14 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 15 Aug 2023 01:59:14 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 15 Aug 2023 01:59:14 -0500 Received: from [172.24.227.94] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37F6xAsx015294; Tue, 15 Aug 2023 01:59:11 -0500 Message-ID: <222cafa8-1d29-7200-cbaa-781a012f4e4d@ti.com> Date: Tue, 15 Aug 2023 12:29:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 0/3] arm64: dts: ti: Introduce AM62P5 SoC and board To: Andrew Davis , Krzysztof Kozlowski , Nishanth Menon , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , References: <20230811184432.732215-1-vigneshr@ti.com> <169179403348.1346194.1236976094485793819.b4-ty@ti.com> <5a1ed797-d29a-e047-ccec-adb1dde6d74f@linaro.org> <696e95b2-59fa-136a-541e-edc86ef91715@ti.com> Content-Language: en-US From: Vignesh Raghavendra In-Reply-To: <696e95b2-59fa-136a-541e-edc86ef91715@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/23 02:24, Andrew Davis wrote: > On 8/14/23 2:26 PM, Krzysztof Kozlowski wrote: >> On 12/08/2023 00:49, Nishanth Menon wrote: >>> Hi Vignesh Raghavendra, >>> >>> On Sat, 12 Aug 2023 00:14:29 +0530, Vignesh Raghavendra wrote: >>>> This series adds basic support for AM62P family of SoCs and >>>> specifically >>>> AM62P5 variant. Also adds AM62P5-SK support with basic peripheral >>>> like UART. >>>> >>>> TRM at [0] and Schematics is at [1] >>>> >>>> [0]: https://www.ti.com/lit/pdf/spruj83 >>>> [1]: https://www.ti.com/lit/zip/sprr487 >>>> >>>> [...] >>> >>> Note: since the changes were trivial, I incorporated the cosmetic >>> fixup suggested by Andrew locally when I applied. I have also dropped >>> bootph property from board's reserved nodes inline with what we did >>> for j721s2[2]. Thanks for the bootlog. >>> >>> I have applied the following to branch ti-k3-dts-next on [1]. >>> Thank you! >>> >>> [1/3] dt-bindings: arm: ti: Add bindings for AM62P5 SoCs >>>        commit: b57fc5cbdbdfd04d44697800a9d59aeb3be2f273 >>> [2/3] arm64: dts: ti: Introduce AM62P5 family of SoCs >>>        commit: 29075cc09f43a024d962da66d2e4f9eb577713d0 >>> [3/3] arm64: dts: ti: Add support for the AM62P5 Starter Kit >>>        commit: 935c4047d42e53a06ec768ddc495a44f6869209c >>> >> >> A bit too fast. simple-mfd *is not allowed* on its own. >> > We have the rule against ['syscon', 'simple-mfd'], which requires a 3rd > specific compatible, but it seems 'simple-mfd' is allowed in the same way > as "simple-bus" (not sure how or why, I would expect a `failed to match any > schema with compatible`, but I'm not getting that either?). > Indeed, I didn't see any warnings from dtbs_check so far > We can add something like simple-mfd.yaml for this to explicitly check that > the compatible has minItems: 2. > > But in this case these seem to be just a typo and we meant "simple-bus" > here, > then it got copy/pasted over our k3 tree. > I dont think "simple-bus" is enough due to presence to TI specific property (ti,sci-dev-id). So this will warrant a separate yaml bindings. I will work towards adding such a file. > So as Nishanth suggested, we can clean this up first thing next cycle, then > add a rule to prevent it from happening for anyone else again while we > are at it. > > Andrew > >> Best regards, >> Krzysztof >> -- Regards Vignesh