mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vlad Zolotarov <vlad@scalemp.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>, Ido Yariv <ido@wizery.com>,
	"Shai Fultheim (Shai@ScaleMP.com)" <Shai@scalemp.com>
Subject: [PATCH v5 0/2] Move x86_cpu_to_apicid to the __read_mostly section
Date: Mon, 11 Jun 2012 12:56:41 +0300	[thread overview]
Message-ID: <2230701.XSbLcxrZ9Q@vlad> (raw)

Pls., consider applying this patch series.
It contains the following changes:
 - Adds two new macros DEFINE_EARLY_PER_CPU_READ_MOSTLY() and
   DECLARE_EARLY_PER_CPU_READ_MOSTLY().
 - Adds "read-mostly" qualifier to the following variables in smp.h:
  - cpu_sibling_map
  - cpu_core_map
  - cpu_llc_shared_map
  - cpu_llc_id
  - cpu_number
  - x86_cpu_to_apicid
  - x86_bios_cpu_apicid
  - x86_cpu_to_logical_apicid

As long as all the variables above are only written during the initialization,
this change is meant to prevent the false sharing. More specifically, on vSMP 
Foundation platform x86_cpu_to_apicid shared the same internode_cache_line 
with frequently written lapic_events.

>From the analysis of the first 33 per_cpu variables  out of 219 (memories they 
describe, to be more specific) the 8 have read_mostly nature 
(tlb_vector_offset, cpu_loops_per_jiffy, xen_debug_irq, etc.) and 25 are 
frequently written (irq_stack_union, gdt_page, exception_stacks, idt_desc, 
etc.). Assuming that the spread of the rest of the per_cpu variables is 
similar, identifying the read mostly memories will make more sense in terms of 
long-term code maintenance comparing to identifying frequently written 
memories.

v5 changes:
- Changed the description of the patch series and patch 2:
  added the analysis of the current per-cpu varibles spread
  between the read-mostly and frequently written groups.

v4 changes:
- Fixed the authors signatures in the patches.

v3 changes:
- Added the missing definitions of DEFINE_EARLY_PER_CPU_READ_MOSTLY()
  and DECLARE_EARLY_PER_CPU_READ_MOSTLY() macros in the !CONFIG_SMP code
  path in arch/x86/include/asm/percpu.h.

thanks,
vlad


                 reply	other threads:[~2012-06-11  9:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2230701.XSbLcxrZ9Q@vlad \
    --to=vlad@scalemp.com \
    --cc=Shai@scalemp.com \
    --cc=hpa@zytor.com \
    --cc=ido@wizery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®