mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: CAI Qian <caiqian@redhat.com>
To: Dave Anderson <anderson@redhat.com>,
	guenter.roeck@ericsson.com, tj@kernel.org, gregkh@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: crash failure with 2.6.36-rc3 vmcore
Date: Sat, 4 Sep 2010 02:01:06 -0400 (EDT)	[thread overview]
Message-ID: <223297751.117871283580066858.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <856089343.1931201283439399228.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>


> crash> mod -S
> 
> mod: invalid structure member offset: attribute_owner
>      FILE: symbols.c  LINE: 8577  FUNCTION: add_symbol_file_kallsyms()
> 
>      MODULE       NAME                   SIZE  OBJECT FILE
> ffffffffa000de60  dm_mod                76230 
> /lib/modules/2.6.36-rc2-mm1-wqfix-mkdfix+/kernel/drivers/md/dm-mod.ko
> [/usr/bin/crash] error trace: 4affb0 => 4f3236 => 4f12b5 => 4e587a
> 
>   4e587a: OFFSET_verify.clone.4+186
>   4f12b5: add_symbol_file+933
>   4f3236: load_module_symbols+566
>   4affb0: do_module_cmd+1264
> 
> mod: invalid structure member offset: attribute_owner
>      FILE: symbols.c  LINE: 8577  FUNCTION: add_symbol_file_kallsyms()
This failure was due to this commit,

commit 6fd69dc578fa0b1bbc3aad70ae3af9a137211707
Author: Guenter Roeck <guenter.roeck@ericsson.com>
Date:   Wed Jul 28 22:09:26 2010 -0700

    sysfs: Remove owner field from sysfs struct attribute
    
    Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
    Acked-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 8bf06b6..3c92121 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -22,14 +22,8 @@ struct kobject;
 struct module;
 enum kobj_ns_type;
 
-/* FIXME
- * The *owner field is no longer used.
- * x86 tree has been cleaned up. The owner
- * attribute is still left for other arches.
- */
 struct attribute {
        const char              *name;
-       struct module           *owner;
        mode_t                  mode;
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
        struct lock_class_key   *key;

       reply	other threads:[~2010-09-04  6:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <856089343.1931201283439399228.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-04  6:01 ` CAI Qian [this message]
2010-09-04 14:20   ` Greg KH
2010-09-04 14:43   ` Guenter Roeck
     [not found] <837631540.119231283612666731.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-04 15:07 ` caiqian
2010-09-04 17:55   ` Guenter Roeck
2010-09-05  3:17     ` CAI Qian
2010-09-05  5:06       ` Guenter Roeck
2010-09-05  6:22         ` Greg KH
     [not found] <471005677.1486991283866304732.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2010-09-07 13:35 ` Dave Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=223297751.117871283580066858.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com \
    --to=caiqian@redhat.com \
    --cc=anderson@redhat.com \
    --cc=gregkh@suse.de \
    --cc=guenter.roeck@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome