From: David Howells <dhowells@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: dhowells@redhat.com, Jean Delvare <khali@linux-fr.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wolfram@the-dreams.de>
Subject: Re: [PATCH] i2c: Add message transfer tracepoints for I2C and SMBUS
Date: Fri, 13 Dec 2013 17:04:14 +0000 [thread overview]
Message-ID: <22364.1386954254@warthog.procyon.org.uk> (raw)
In-Reply-To: <20131213104806.4fb56012@gandalf.local.home>
Steven Rostedt <rostedt@goodmis.org> wrote:
> > Would it be possible to print this as a string rather than a number?
> > The protocol numbers are completely arbitrary, so the reader would have
> > to open i2c.h each time to figure out what is what.
>
> That can be done in the TP_printk() with:
>
> ".. %s ..", ..,
> __print_symbolic(__entry->protocol,
> { I2C_SMBUS_QUICK , "QUICK" },
> { I2C_SMBUS_BYTE , "BYTE" },
> { I2C_SMBUS_BYTE_DATA , "BYTE_DATA" },
> [...]
> { I2C_SMBUS_I2C_BLOCK_DATA, "I2C_BLOCK_DATA"}), ...
What happens if the number isn't in the table?
David
next prev parent reply other threads:[~2013-12-13 17:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 14:26 David Howells
2013-12-13 15:33 ` Jean Delvare
2013-12-13 15:48 ` Steven Rostedt
2013-12-13 17:04 ` David Howells [this message]
2013-12-13 17:39 ` Steven Rostedt
2013-12-13 16:05 ` David Howells
2013-12-13 16:53 ` Jean Delvare
2013-12-13 17:26 ` David Howells
2013-12-13 18:13 ` Steven Rostedt
2013-12-14 0:16 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22364.1386954254@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=wolfram@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome