From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231AbcKRQ7F convert rfc822-to-8bit (ORCPT ); Fri, 18 Nov 2016 11:59:05 -0500 Received: from mga01.intel.com ([192.55.52.88]:4100 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbcKRQ7E (ORCPT ); Fri, 18 Nov 2016 11:59:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,510,1473145200"; d="scan'208";a="193061831" From: "Reshetova, Elena" To: Peter Zijlstra CC: "gregkh@linuxfoundation.org" , "keescook@chromium.org" , "will.deacon@arm.com" , "arnd@arndb.de" , "tglx@linutronix.de" , "mingo@kernel.org" , "hpa@zytor.com" , "dave@progbits.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC][PATCH 7/7] kref: Implement using refcount_t Thread-Topic: [RFC][PATCH 7/7] kref: Implement using refcount_t Thread-Index: AQHSPp8nZI2aGULSnkSyKlUn6xiKNqDeiSUQgAALYCCAAAHXAIAAZSTw Date: Fri, 18 Nov 2016 16:58:52 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C14B3B@IRSMSX102.ger.corp.intel.com> References: <20161114173946.501528675@infradead.org> <20161114174446.832175072@infradead.org> <2236FBA76BA1254E88B949DDB74E612B41C14924@IRSMSX102.ger.corp.intel.com> <20161118105206.GM3117@twins.programming.kicks-ass.net> In-Reply-To: <20161118105206.GM3117@twins.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Could you please fix you mailer to not unwrap the emails? I wish I understand what you mean by "unwrap"... ? On Fri, Nov 18, 2016 at 10:47:40AM +0000, Reshetova, Elena wrote: > >Provide refcount_t, an atomic_t like primitive built just for > >refcounting. It provides overflow and underflow checks as well as > >saturation semantics such that when it overflows, we'll never attempt > >to free it again, ever. > > >Peter do you have the changes to the refcount_t interface compare to > >the version in this patch? We are now starting working on atomic_t > >--> refcount_t conversions and it would save a bit of work to have > >latest version from you that we can be based upon. > > Oh, and if we define refcount_t to be just atomic_t underneath, what > about the other atomic_long_t, local_t and atomic64_t cases when it is > used for recounting? I don't feel good just simply changing them to > become atomic_t under refcount_t wrapper..... > Is there anybody using local_t ? That seems 'creative' and highly questionable. I am not yet sure about refcounts, but local_t itself is used in couple of places. >As for atomic_long_t there's very few, I'd leave them be for now, Ok, I have started a list on them to keep track, but we need to do them also. There is no reason for them not to be refcounts, since so far the ones I see are classical refcounts. >and I couldn't find a single atomic64_t refcount user. I will check when I get over the atomic_t and atomic_long.