From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753069AbdBTMUO (ORCPT ); Mon, 20 Feb 2017 07:20:14 -0500 Received: from mga09.intel.com ([134.134.136.24]:13715 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195AbdBTMUK (ORCPT ); Mon, 20 Feb 2017 07:20:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,186,1484035200"; d="scan'208";a="1100177972" From: "Reshetova, Elena" To: Borislav Petkov CC: "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "sparclinux@vger.kernel.org" , "linux-s390@vger.kernel.org" , "kvm@vger.kernel.org" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "tglx@linutronix.de" , "mingo@redhat.com" , "Luck, Tony" , "hpa@zytor.com" , Hans Liljestrand , Kees Cook , David Windsor Subject: RE: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to refcount_t Thread-Topic: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to refcount_t Thread-Index: AQHSi2mQu52OxzhWvEKq74cyl1BatKFxvwKAgAAQN3A= Date: Mon, 20 Feb 2017 12:20:04 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C4D921@IRSMSX102.ger.corp.intel.com> References: <1487588781-15123-1-git-send-email-elena.reshetova@intel.com> <1487588781-15123-3-git-send-email-elena.reshetova@intel.com> <20170220111727.7vohleiu2btmsx3g@pd.tnic> In-Reply-To: <20170220111727.7vohleiu2btmsx3g@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v1KCKJpP024161 > On Mon, Feb 20, 2017 at 01:06:19PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > > > Signed-off-by: Elena Reshetova > > Signed-off-by: Hans Liljestrand > > Signed-off-by: Kees Cook > > Signed-off-by: David Windsor > > That SOB chain tells me that you wrote the patch and Hans, Kees and > David handled it in some way and the last one - David - is sending it to > me. It doesn't look like that though. > > So what are you trying to express with it? Whole refcount conversion was a long piece of work and the above people contributed to this code either as writes or reviewers or both. I am primary writer of the code and I am handing patches in our tree and sending them out, so how exactly the above should look like? Please note that we have about 300 patches and if I have to modify each sign-off to reflect who contributed to each commit in what particular way, I will go insane. Best Regards, Elena.