From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbdCPHwf (ORCPT ); Thu, 16 Mar 2017 03:52:35 -0400 Received: from mga03.intel.com ([134.134.136.65]:49285 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbdCPHwd (ORCPT ); Thu, 16 Mar 2017 03:52:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,170,1486454400"; d="scan'208";a="236828494" From: "Reshetova, Elena" To: Pablo Neira Ayuso CC: "netfilter-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kadlec@blackhole.kfki.hu" , "peterz@infradead.org" , "keescook@chromium.org" Subject: RE: [PATCH 0/7] net, netfilter refcounter conversions Thread-Topic: [PATCH 0/7] net, netfilter refcounter conversions Thread-Index: AQHSnXzST9Vjyjg8l02ldRiPCWJ6j6GV3cCAgAE7PWA= Date: Thu, 16 Mar 2017 07:52:19 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C59A26@IRSMSX102.ger.corp.intel.com> References: <1489576245-19472-1-git-send-email-elena.reshetova@intel.com> <20170315130213.GA30233@salvia> In-Reply-To: <20170315130213.GA30233@salvia> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2G7qd1h015524 > On Wed, Mar 15, 2017 at 01:10:38PM +0200, Elena Reshetova wrote: > > This series, for the netfilter subsystem, replaces atomic_t reference > > counters with the new refcount_t type and API (see include/linux/refcount.h). > > By doing this we prevent intentional or accidental > > underflows or overflows that can led to use-after-free vulnerabilities. > > > > Please take the series to your tree if there are no run-time issues. > > Could you collapse all of your patches into one single? They are all > part of the same logical change to me. > > > 21 files changed, 85 insertions(+), 75 deletions(-) > > The diffstat is small enough to do what I'm asking. Sure. The reason why they are separated is that it is easier to review them this way IMO and find mistakes (I found many after I split all networking patches into one per variable). But I guess for merge, it is easier to have them collapsed, so I am going to send you a new version shortly. Best Regards, Elena. > > Thanks!