From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbdKXOoq convert rfc822-to-8bit (ORCPT ); Fri, 24 Nov 2017 09:44:46 -0500 Received: from mga04.intel.com ([192.55.52.120]:39686 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbdKXOoo (ORCPT ); Fri, 24 Nov 2017 09:44:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,447,1505804400"; d="scan'208";a="6590813" From: "Reshetova, Elena" To: Alasdair G Kergon CC: Zdenek Kabelac , "dm-devel@redhat.com" , "linux-bcache@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-raid@vger.kernel.org" , "kent.overstreet@gmail.com" , "koverstreet@google.com" , "ejt@redhat.com" , "snitzer@redhat.com" , "shli@kernel.org" , "peterz@infradead.org" , "keescook@chromium.org" Subject: RE: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t Thread-Topic: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t Thread-Index: AQHTZS0pA995MJsutUqIGxS34I4IA6MjmkGA Date: Fri, 24 Nov 2017 14:44:40 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B802C2094@IRSMSX102.ger.corp.intel.com> References: <1508485059-21881-1-git-send-email-elena.reshetova@intel.com> <1508485059-21881-5-git-send-email-elena.reshetova@intel.com> <92f8c04f-ef1a-c41b-e82f-8d68a3ec84b5@redhat.com> <2236FBA76BA1254E88B949DDB74E612B802C1F4D@IRSMSX102.ger.corp.intel.com> <20171124140413.GG5952@agk-dp.fab.redhat.com> In-Reply-To: <20171124140413.GG5952@agk-dp.fab.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJkZjQ3ZGItYmY4YS00ZmU4LWFlZWMtNzFlMTQyODRiZjkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJldW8wS2VGaVBaS1daUTNmOUFnMGhlNHRCTDZ2dm1jVkJEYmtoSXdrOUNTbTVnUDFudWpSMzJWbVcrQ3dKbFhEIn0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Fri, Nov 24, 2017 at 08:29:42AM +0000, Reshetova, Elena wrote: > > By looking at the code, I don't see where the change in the reference counting > > could have caused this. > > The cause was the bug I identified in patch 3, not this patch. Oh, ok, because I could not figure an issue with this patch. I will send the fixing patch shortly. Best Regards, Elena. > > The regression is easily hit - tables that reference the same underlying device > more than once are very common. > > Alasdair