From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBBFAC10F0E for ; Mon, 15 Apr 2019 06:31:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A12AF20825 for ; Mon, 15 Apr 2019 06:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726254AbfDOGbI convert rfc822-to-8bit (ORCPT ); Mon, 15 Apr 2019 02:31:08 -0400 Received: from mga05.intel.com ([192.55.52.43]:48388 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbfDOGbH (ORCPT ); Mon, 15 Apr 2019 02:31:07 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2019 23:31:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,352,1549958400"; d="scan'208";a="140721804" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga008.fm.intel.com with ESMTP; 14 Apr 2019 23:31:05 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.21]) by IRSMSX108.ger.corp.intel.com ([169.254.11.82]) with mapi id 14.03.0415.000; Mon, 15 Apr 2019 07:31:04 +0100 From: "Reshetova, Elena" To: Julia Lawall , "Jan Alexander Steffens (heftig)" CC: "James E.J. Bottomley" , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kbuild-all@01.org" Subject: RE: [PATCH] ZEN: fix platform_no_drv_owner.cocci warnings Thread-Topic: [PATCH] ZEN: fix platform_no_drv_owner.cocci warnings Thread-Index: AQHU8oYKwWji7w/b90CRq2E0Weg20qY8w/nA Date: Mon, 15 Apr 2019 06:31:03 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612BA4C4F65E@IRSMSX102.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjQzZGRhZTctY2Y5OC00NzAwLWIxMWUtZDk5NmZkNGU0ZDMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDVTdk15UE14MCt6b2JjRTUzcXR2alhXZ1pqcE1xTFJLQVJcL3JhbjQrZEsrNE5FXC81REJObkVrTnlqQXQ0b3I2In0= x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: kbuild test robot > > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Fixes: 26e2aa63d568 ("ZEN: Add VHBA driver") > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall > > --- > > There was also a report about: > > drivers/scsi/vhba/vhba.c:184:8-27: atomic_dec_and_test variation before > object free at line 185. > > that Elena may want to comment on. > > Yes, on a quick look it seems that you should be using refcount_t type and not atomic_t for your reference counter, as you use it as classical refcounter, i.e. free the object upon reaching zero, etc: static void vhba_device_put (struct vhba_device *vdev) { if (atomic_dec_and_test(&vdev->refcnt)) { kfree(vdev); } } Any reason why you didn't use refcount_t type to begin with? Best Regards, Elena.