From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59C8C433E6 for ; Tue, 9 Feb 2021 12:21:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B47164E28 for ; Tue, 9 Feb 2021 12:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229815AbhBIMVN (ORCPT ); Tue, 9 Feb 2021 07:21:13 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:12885 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbhBIMVL (ORCPT ); Tue, 9 Feb 2021 07:21:11 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DZhlD3HWsz7jM7; Tue, 9 Feb 2021 20:19:04 +0800 (CST) Received: from [127.0.0.1] (10.40.188.87) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Tue, 9 Feb 2021 20:20:18 +0800 Subject: Re: [RFC PATCH v3 1/2] mempinfd: Add new syscall to provide memory pin To: Greg KH References: <1612685884-19514-2-git-send-email-wangzhou1@hisilicon.com> <2e6cf99f-beb6-9bef-1316-5e58fb0aa86e@hisilicon.com> CC: Andy Lutomirski , , , , , , "Andrew Morton" , Alexander Viro , , , , , , , , Sihang Chen From: Zhou Wang Message-ID: <2237506a-0c98-7ba6-5d5f-b60b637174c5@hisilicon.com> Date: Tue, 9 Feb 2021 20:20:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.40.188.87] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/9 20:01, Greg KH wrote: > On Tue, Feb 09, 2021 at 07:58:15PM +0800, Zhou Wang wrote: >> On 2021/2/9 17:37, Greg KH wrote: >>> On Tue, Feb 09, 2021 at 05:17:46PM +0800, Zhou Wang wrote: >>>> On 2021/2/8 6:02, Andy Lutomirski wrote: >>>>> >>>>> >>>>>> On Feb 7, 2021, at 12:31 AM, Zhou Wang wrote: >>>>>> >>>>>> SVA(share virtual address) offers a way for device to share process virtual >>>>>> address space safely, which makes more convenient for user space device >>>>>> driver coding. However, IO page faults may happen when doing DMA >>>>>> operations. As the latency of IO page fault is relatively big, DMA >>>>>> performance will be affected severely when there are IO page faults. >>>>>> From a long term view, DMA performance will be not stable. >>>>>> >>>>>> In high-performance I/O cases, accelerators might want to perform >>>>>> I/O on a memory without IO page faults which can result in dramatically >>>>>> increased latency. Current memory related APIs could not achieve this >>>>>> requirement, e.g. mlock can only avoid memory to swap to backup device, >>>>>> page migration can still trigger IO page fault. >>>>>> >>>>>> Various drivers working under traditional non-SVA mode are using >>>>>> their own specific ioctl to do pin. Such ioctl can be seen in v4l2, >>>>>> gpu, infiniband, media, vfio, etc. Drivers are usually doing dma >>>>>> mapping while doing pin. >>>>>> >>>>>> But, in SVA mode, pin could be a common need which isn't necessarily >>>>>> bound with any drivers, and neither is dma mapping needed by drivers >>>>>> since devices are using the virtual address of CPU. Thus, It is better >>>>>> to introduce a new common syscall for it. >>>>>> >>>>>> This patch leverages the design of userfaultfd and adds mempinfd for pin >>>>>> to avoid messing up mm_struct. A fd will be got by mempinfd, then user >>>>>> space can do pin/unpin pages by ioctls of this fd, all pinned pages under >>>>>> one file will be unpinned in file release process. Like pin page cases in >>>>>> other places, can_do_mlock is used to check permission and input >>>>>> parameters. >>>>> >>>>> >>>>> Can you document what the syscall does? >>>> >>>> Will add related document in Documentation/vm. >>> >>> A manpage is always good, and will be required eventually :) >> >> manpage is maintained in another repo. Do you mean add a manpage >> patch in this series? > > It's good to show how it will be used, don't you think? Agree, will add it in next version. Thanks, Zhou > > thanks, > > greg k-h > > . >