mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Antoine Tenart <antoine.tenart@bootlin.com>,
	davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com,
	hkallweit1@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: mscc: fix PHYs using the vsc8574_probe
Date: Fri, 29 May 2020 13:11:00 +0200	[thread overview]
Message-ID: <223CE44E-8ACF-4F31-B5EC-FA5468F9D54A@walle.cc> (raw)
In-Reply-To: <20200529094909.1254629-1-antoine.tenart@bootlin.com>

Am 29. Mai 2020 11:49:09 MESZ schrieb Antoine Tenart <antoine.tenart@bootlin.com>:
>PHYs using the vsc8574_probe fail to be initialized and their
>config_init return -EIO leading to errors like:
>"could not attach PHY: -5".
>
>This is because when the conversion of the MSCC PHY driver to use the
>shared PHY package helpers was done, the base address retrieval and the
>base PHY read and write helpers in the driver were modified. In
>particular, the base address retrieval logic was moved from the
>config_init to the probe. But the vsc8574_probe was forgotten. This
>patch fixes it.
>
>Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
>Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>

Reviewed-by: Michael Walle <michael@walle.cc>

thanks, 
-michael


  reply	other threads:[~2020-05-29 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  9:49 Antoine Tenart
2020-05-29 11:11 ` Michael Walle [this message]
2020-05-29 15:45 ` Florian Fainelli
2020-05-29 19:45 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=223CE44E-8ACF-4F31-B5EC-FA5468F9D54A@walle.cc \
    --to=michael@walle.cc \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®