From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B2342BEB3 for ; Thu, 30 Jul 2026 12:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785412866; cv=none; b=IHqZSjvPtYea1itXbMNkB2ws0PQiUcTCwYSROqpMEUA2IKF0W/3Cc9ne4cTqqXpwN3FtnOajbUHs6uDsA7j8nBIc2qJBI3E05uPOtMf+yZW6nMriWdHEbHdTUKMs0LkFPhcGesZHB6Q+FZa+MMd+XrD4V38uFtME8JMil62gRpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785412866; c=relaxed/simple; bh=csAFNfO40NZPi2DR6Skicl9UMEC8wvsLVH3colafHSo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NFqwDjYffT8GoOtbqnW2fa4KD8vH3iw7gNXleHxuJfYFtKIFFHoFy5T56QtibXTCwjlI7An7FV1UXX1g9XdjtVul27kGfD3005cPSnpfbkA3dDKy/pGOg4wuXy0UAoC4b9lFtYZWkdnlggplcNyRArs6mtZ7Ziq4F+Sy6lD9J+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T9VtASuf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T9VtASuf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10C6D1F00A3A; Thu, 30 Jul 2026 12:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785412865; bh=DHf18rSlNZKDZKjkZzbb9NgJagDAkYivuavqTnujb3E=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=T9VtASufsi6UhkYBym/rW+7GIcQGoutZ15mvneRHOETKxWcDl45W8Yhwy6V5bQR2G 9RZoWt+/awfySOhU5icPHSUWu3HdhWH4YGGtLV58it9SnbVQwcyBt9Wdik+JIcE/S4 njdXmNbigKVKE1oytHZlvxvGONIcf7ZtJZS/bKREHbubj9mbiHxfZf9E4Ey/sjq3AN 3e24tBRr3ZuOrG3KzQ8RKE4kRjCjJ4KPb/kb0agLQ/6k7NTexEIDQeq6mpgOocANHm 5bSh1uieJUfJIerYD0L0RMoHd+YybKhy7cRsfj0d0bRznpjaARbNVZPHBW82tgOhz+ kKRh4qQcNM22Q== Message-ID: <223afb76-9f6f-48a1-a5c5-beb1a641916c@kernel.org> Date: Thu, 30 Jul 2026 14:01:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup To: Krzysztof Kozlowski Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Herve Codina , Paul Louvel References: <04dc047f8958a78a920f0a88ca3bd8bf70c56187.1785333986.git.chleroy@kernel.org> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 30/07/2026 à 13:14, Krzysztof Kozlowski a écrit : > On 29/07/2026 16:10, Christophe Leroy (CS GROUP) wrote: >> Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a >> proper platform driver") qe_add_gpiochips() was walking the device >> tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank". >> >> After that commit the discovery is handled by the platform core, >> therefore it is necessary to call of_platform_default_populate() on >> the par_io node. >> >> Fixes: 156460811def ("soc: fsl: qe: Change GPIO driver to a proper platform driver") >> Signed-off-by: Christophe Leroy (CS GROUP) >> --- >> drivers/soc/fsl/qe/qe_io.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/soc/fsl/qe/qe_io.c b/drivers/soc/fsl/qe/qe_io.c >> index a5e2d0e5ab51..02ca556c8db0 100644 >> --- a/drivers/soc/fsl/qe/qe_io.c >> +++ b/drivers/soc/fsl/qe/qe_io.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -184,3 +185,17 @@ int par_io_of_config(struct device_node *np) >> return 0; >> } >> EXPORT_SYMBOL(par_io_of_config); >> + >> +static int __init par_io_populate(void) >> +{ >> + struct device_node *np = of_find_node_by_name(NULL, "par_io"); > > No, node name must not be ABI. Especially wrong node name. What's wrong with the node name ? Regardless, I messed it up, I wanted to use type but copy/pasted of_find_node_by_name(NULL, "par_io") from quirk_mpc8360e_qe_enet10() in arch/powerpc/platforms/83xx/km83xx.c instead. Is it OK to use of_find_node_by_type(NULL, "par_io") instead ? We have: $ git grep par_io arch/powerpc/boot/dts/ arch/powerpc/boot/dts/fsl/mpc8568mds.dts: par_io@e0100 { arch/powerpc/boot/dts/fsl/mpc8568si-post.dtsi: par_io@e0100 { arch/powerpc/boot/dts/fsl/mpc8568si-post.dtsi: device_type = "par_io"; arch/powerpc/boot/dts/fsl/mpc8569mds.dts: par_io@e0100 { arch/powerpc/boot/dts/fsl/mpc8569si-post.dtsi: par_io@e0100 { arch/powerpc/boot/dts/fsl/mpc8569si-post.dtsi: device_type = "par_io"; arch/powerpc/boot/dts/fsl/p1021mds.dts: par_io@e0100 { arch/powerpc/boot/dts/fsl/p1021mds.dts: device_type = "par_io"; arch/powerpc/boot/dts/fsl/p1025rdb.dtsi: par_io@e0100 { arch/powerpc/boot/dts/fsl/p1025rdb.dtsi: device_type = "par_io"; arch/powerpc/boot/dts/fsl/p1025twr.dtsi: par_io@e0100 { arch/powerpc/boot/dts/fsl/p1025twr.dtsi: device_type = "par_io"; arch/powerpc/boot/dts/kmeter1.dts: par_io@1400 { arch/powerpc/boot/dts/kmeter1.dts: compatible = "fsl,mpc8360-par_io"; arch/powerpc/boot/dts/mpc832x_rdb.dts: par_io@1400 { arch/powerpc/boot/dts/mpc832x_rdb.dts: device_type = "par_io"; Thanks Christophe