From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25103ACF15 for ; Tue, 20 Jan 2026 07:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895313; cv=none; b=CIEfC3y+fpFnIMIBhu4tNsfGmlR4RPwPLMLB6zZ5/VzJUtmkkLpZNl9LbEHb4Zc71XQ4skJ1mF4QMTW88BxnLWJ3ikrV+yYxHhW2xkBU6aW7wXT4RNrqOrcQvWfWZdt/wfnxCa5JpMphIOdjnYWT6osnQCPQoUkRl3yM26D7mAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895313; c=relaxed/simple; bh=Dl2oWfBwtiPo7WzVz9Y3r/pgOLtbYy6Lx+/AgLj3Y70=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=B3xm/yePlXPU3H3arbUMIhHAocNYHeB3CV76bsNNDFt3dv192W1sCioW01BIZYVuL77OyCZ2qMgDFkCk5/17gEGirG57tXSrA7YY92GagWQdObpSqJ73GOYQ2bXijTM1MNIfCBTWHolU/nSvvNvpLv+eFXU1KGjsTP0u1DWsUkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ATqqHmyy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dnB2IJQK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ATqqHmyy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dnB2IJQK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768895310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dl2oWfBwtiPo7WzVz9Y3r/pgOLtbYy6Lx+/AgLj3Y70=; b=ATqqHmyy1NTs7k1Qxay/o8myZsQ89rtyC68/yPuOVo8oGFM/TM2wQA9X2vnbH1i7odMi/J eTsA+VUPVEYjXuDvXIUX7H7fPIkCCkYqn5pqi4Le4AbCC8YY2V8LeH9XdrDjg/8D2kizh6 cqC86oyi0QXI5Yl1CtgR9gYLZCBiLFI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-poyo-y5GNe-GIRA9TSzL_g-1; Tue, 20 Jan 2026 02:48:28 -0500 X-MC-Unique: poyo-y5GNe-GIRA9TSzL_g-1 X-Mimecast-MFC-AGG-ID: poyo-y5GNe-GIRA9TSzL_g_1768895308 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4779d8fd4ecso25228925e9.1 for ; Mon, 19 Jan 2026 23:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768895307; x=1769500107; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Dl2oWfBwtiPo7WzVz9Y3r/pgOLtbYy6Lx+/AgLj3Y70=; b=dnB2IJQKCuD9Y5/wf5QmeHm/kvw45tTcg2/BXZv8AyqvD+HfoUf8jxggeT8uQ/qSD3 ttijDDxLuCr/k6oSmXa4FlOMuynU8O+2D1pSQfLMXx67mDDOIDM2bSFc51Q2NrSjIZ40 PHsPSOkInmsebzKd7wV7QyTokoYoNAjxu6Ipv9EqOElJCvyyHO5wVekI+XkRSgfc4hZg gZl85DmLfRbA7COQYy9WhbPFlWDmVT9M2CXbqy9cM+yr9zsdFonI3xclusCp8NwGwHFU YuUdT1EjuMaZw6vVUhSXYarIn3Stj9h87LDxO0M5NOwQdQ5OvALr8v+ENAgzcQmdFsTG BWuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768895307; x=1769500107; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dl2oWfBwtiPo7WzVz9Y3r/pgOLtbYy6Lx+/AgLj3Y70=; b=vZjT95AXR9o018wodea7UGpzUcjvsVgmtdxYe+g693z3i3M/m9pVfgQE4fOgU/UqNx i03ZwU53M0TuDe8s0Ad+j7BEsLi552ZOfcSTY6T871NEKR5LlD64K7TJBNKvRi3tftMI fEwLj3X4sizdfOCcQ6L8LQsbGyfK/R7Z4JZuaWdOLj7ljkKwkdAcTmBYX4YH3PuLJJo4 JGJeg9eXHN00RhaBVIyIhD0Z3vs/OZq76efZxbVWpzKiPdyvm3PeOn12qvOfckpnabMO 8un1GKS3JDhm+KL4+O/GAlkRF0dIoE++COvYWsj2xdFXMbJHe2l8ZimH0jB8mZurHvcQ G4XA== X-Forwarded-Encrypted: i=1; AJvYcCWvptrJOFV97SMO3GYPkwwsxIPdXMUHk1u0IB+NsvBlVPIQfQ5gzoNjVHv6Bj8pvLFdlyRJqe8U6RyG5cs=@vger.kernel.org X-Gm-Message-State: AOJu0YxwtnTnqI/xM/bN7FuvZLhg544Y6xbh8t5+YIlGrom7SJqq7Izm TjfpJHwMj+NR1zFcHqDwVb4GRUD6pkxd1Rh2uCS7hVrF2XkanFcLm/0EvKokv2IkXzo/REnalm+ Zbas1t20xV6/OcA0AzUbv+Rx4s89CDpjHX2eC+AsAN0EDYABLK1Al2wA4mMaMMsYWbBlr13JU0P gn X-Gm-Gg: AY/fxX61VHs6EXAtmNmB2XDhsu45QflFWPKv9V9SBslA8XvNn6/AecmOWEOpgkpZNvH ZknqyUuO/SLAfucZDhs0bvmDy94nfincS/8zkb+45eKaetoevEV9OP7ww3cY6G0QRtUYvYwNeWB PAnXUOQjQ/HCEZTso5O9MqRDXaYDY5fQvUFH4cx5QpOIpRu8Ajk4jo0xF1+XRe+r1uw+5KxSp/P g/qsY6eI7tNEL2Emk0XOoln+w1cqug0CTNz1KW4OWG+XD0vQ9tnA7EPT4staXjyfk+Pp5F3QJh1 DFShpwEzP+HAqNENB2uxZ9aEDqxueG/vUF8ftmjJ3fbX5PxKzlK0hUlbxIw0TsFUuODOmPaKfYT Hlg6Q9ZWW23LrcFQDf9iojW2zOWt8yEYfJgtCz70aMMfk+0B+/cg/j9kWbBL9+kqX2S2oZZXAYD r9K7TnEINh X-Received: by 2002:a05:600c:300b:b0:47e:e452:ec12 with SMTP id 5b1f17b1804b1-47f429033bdmr130927325e9.15.1768895307525; Mon, 19 Jan 2026 23:48:27 -0800 (PST) X-Received: by 2002:a05:600c:300b:b0:47e:e452:ec12 with SMTP id 5b1f17b1804b1-47f429033bdmr130927205e9.15.1768895307114; Mon, 19 Jan 2026 23:48:27 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356992c6f2sm27197638f8f.19.2026.01.19.23.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 23:48:26 -0800 (PST) Message-ID: <223e99ae6c154a189a372bb51875d3998c1f9a50.camel@redhat.com> Subject: Re: [PATCH 08/26] rv/rvgen: simplify boolean comparison From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 08:48:25 +0100 In-Reply-To: <20260119205601.105821-9-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-9-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > Replace explicit boolean comparison with truthiness test in the dot2c > module. The previous implementation used the redundant pattern of > comparing a boolean variable directly to False, which is not idiomatic > Python and adds unnecessary verbosity to the code. >=20 > Python's truthiness allows for more concise and readable boolean > checks. The expression "if not first" is clearer and more Pythonic > than "if first =3D=3D False" while maintaining identical semantics. This > pattern is preferred in PEP 8 and is the standard approach in the > Python community. >=20 > This change continues the ongoing code quality improvements to align > the codebase with modern Python best practices. >=20 > Signed-off-by: Wander Lairson Costa I'm starting to wonder if those simple cleanup patches with a tiny change a= nd 3 paragraph of commit message aren't a bit too noisy. We may put at least the simple ones together. Other than that: Reviewed-by: Gabriele Monaco Thanks, Gabriele > --- > =C2=A0tools/verification/rvgen/rvgen/dot2c.py | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/dot2c.py > b/tools/verification/rvgen/rvgen/dot2c.py > index c97bb9466af6d..fa9e9ae16640f 100644 > --- a/tools/verification/rvgen/rvgen/dot2c.py > +++ b/tools/verification/rvgen/rvgen/dot2c.py > @@ -202,7 +202,7 @@ class Dot2c(Automata): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 line =3D "" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 first =3D True > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for state in self.states= : > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if fi= rst =3D=3D False: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if no= t first: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 line =3D line + ', ' > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = else: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 first =3D False