From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: next-20140312 - build error in drivers/acpi/sleep.c
Date: Thu, 13 Mar 2014 14:48:31 -0400 [thread overview]
Message-ID: <22429.1394736511@turing-police.cc.vt.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
Seen in the most recent linux-next with a CONFIG_SUSPEND=n .config:
CC drivers/acpi/sleep.o
drivers/acpi/sleep.c: In function 'acpi_sleep_init':
drivers/acpi/sleep.c:808:2: error: implicit declaration of function 'acpi_sleep_state_supported' [-Werror=implicit-function-declaration]
if (acpi_sleep_state_supported(ACPI_STATE_S5)) {
^
cc1: some warnings being treated as errors
make[2]: *** [drivers/acpi/sleep.o] Error 1
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2
Function is defined inside a #ifdef CONFIG_SUSPEND, but used outside of
one in acpi_sleep_init().
git blame points at commit eaa54ccbc:
commit eaa54ccbcf81de987e6978ad457cc9e425b7a8db
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Tue Mar 11 14:08:58 2014 +0100
ACPI / sleep: Add extra checks for HW Reduced ACPI mode sleep states
If the HW Reduced ACPI mode bit is set in the FADT, ACPICA uses
the optional sleep control and sleep status registers for making
the system enter sleep states (including S5), so it is not possible
to use system sleep states or power it off using ACPI if the HW
Reduced ACPI mode bit is set and those registers are not available.
For this reason, add a new function, acpi_sleep_state_supported(),
checking if the HW Reduced ACPI mode bit is set and whether or not
system sleep states are usable in that case in addition to checking
the return value of acpi_get_sleep_type_data() and make the ACPI
sleep setup routines use that function to check the availability of
system sleep states.
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next reply other threads:[~2014-03-13 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 18:48 Valdis Kletnieks [this message]
2014-03-13 21:23 ` Rafael J. Wysocki
2014-03-13 22:53 ` David Rientjes
2014-03-14 0:08 ` Fengguang Wu
2014-03-14 20:56 ` Valdis.Kletnieks
2014-03-16 0:30 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22429.1394736511@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®