From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: josh@joshtriplett.org
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c
Date: Thu, 27 Feb 2014 01:07:28 +0100 [thread overview]
Message-ID: <2246444.oMnRuKn9p2@vostro.rjw.lan> (raw)
In-Reply-To: <20140226221651.GA24021@cloud>
On Wednesday, February 26, 2014 02:16:51 PM josh@joshtriplett.org wrote:
> On Wed, Feb 26, 2014 at 10:56:45PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote:
> > > Mark function as static in cpufreq.c because it is not
> > > used outside this file.
> > >
> > > This eliminates the following warning in cpufreq.c:
> > > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
> > >
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> >
> > v2 has been Reviewed-by: Josh already, right?
>
> Feel free to forward-propagate to v3 as well, if that helps.
OK
Applied, thanks!
> > > ---
> > > Changes since v1:
> > > Incorrect Fix
> > > Changes since v2:
> > > Show Changelog
> > >
> > > drivers/cpufreq/cpufreq.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > index 08ca8c9..54fd670 100644
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> > > /*********************************************************************
> > > * SYSFS INTERFACE *
> > > *********************************************************************/
> > > -ssize_t show_boost(struct kobject *kobj,
> > > +static ssize_t show_boost(struct kobject *kobj,
> > > struct attribute *attr, char *buf)
> > > {
> > > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
> > >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-02-26 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 15:46 [PATCH] drivers: cpufreq: Remove unused function " Rashika Kheria
2014-02-26 16:13 ` Josh Triplett
2014-02-26 16:42 ` [PATCH v3] drivers: cpufreq: Mark function as static " Rashika Kheria
2014-02-26 21:56 ` Rafael J. Wysocki
2014-02-26 22:16 ` josh
2014-02-27 0:07 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2246444.oMnRuKn9p2@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome