From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759507AbbA2XlD (ORCPT ); Thu, 29 Jan 2015 18:41:03 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:61252 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752349AbbA2XlA (ORCPT ); Thu, 29 Jan 2015 18:41:00 -0500 From: "Rafael J. Wysocki" To: Octavian Purdila Cc: linus.walleij@linaro.org, lee.jones@linaro.org, johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, heikki.krogerus@intel.com, mika.westerberg@linux.intel.com, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/4] ACPICA: take ACPI_MTX_INTERPRETER in acpi_unload_table_id Date: Fri, 30 Jan 2015 01:03:48 +0100 Message-ID: <2246788.mX5nmqqL2I@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1418746353-3481-2-git-send-email-octavian.purdila@intel.com> References: <1418746353-3481-1-git-send-email-octavian.purdila@intel.com> <1418746353-3481-2-git-send-email-octavian.purdila@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, December 16, 2014 06:12:30 PM Octavian Purdila wrote: > acpi_tb_delete_namespace_by_owner expects ACPI_MTX_INTERPRETER to be > taken. This fixes the following issue: > > ACPI Error: Mutex [0x0] is not acquired, cannot release (20141107/utmutex-322) > Call Trace: > [] dump_stack+0x4f/0x7b > [] acpi_ut_release_mutex+0x47/0x67 > [] acpi_tb_delete_namespace_by_owner+0x57/0x8d > [] acpi_unload_table_id+0x3a/0x5e > > Signed-off-by: Octavian Purdila I've queued up this one for 3.20. > --- > drivers/acpi/acpica/tbxface.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c > index 6482b0d..9520ae1 100644 > --- a/drivers/acpi/acpica/tbxface.c > +++ b/drivers/acpi/acpica/tbxface.c > @@ -281,6 +281,11 @@ acpi_status acpi_unload_table_id(acpi_owner_id id) > > ACPI_FUNCTION_TRACE(acpi_unload_table_id); > > + status = acpi_ut_acquire_mutex(ACPI_MTX_INTERPRETER); > + if (ACPI_FAILURE(status)) { > + return_ACPI_STATUS(status); > + } > + > /* Find table in the global table list */ > for (i = 0; i < acpi_gbl_root_table_list.current_table_count; ++i) { > if (id != acpi_gbl_root_table_list.tables[i].owner_id) { > @@ -297,6 +302,8 @@ acpi_status acpi_unload_table_id(acpi_owner_id id) > acpi_tb_set_table_loaded_flag(i, FALSE); > break; > } > + > + (void)acpi_ut_release_mutex(ACPI_MTX_INTERPRETER); > return_ACPI_STATUS(status); > } > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.