From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228AbcIEHdB (ORCPT ); Mon, 5 Sep 2016 03:33:01 -0400 Received: from ml01.weidahitech.com ([61.222.87.235]:1078 "EHLO ml01.weidahitech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbcIEHc7 (ORCPT ); Mon, 5 Sep 2016 03:32:59 -0400 From: Hn Chen To: Dmitry Torokhov CC: "linux-input@vger.kernel.org" , lkml , Benjamin Tissoires Subject: RE: [PATCH] Input: wdt87xx_i2c - support new body WDT8752 Thread-Topic: [PATCH] Input: wdt87xx_i2c - support new body WDT8752 Thread-Index: AQHR7W/4mOyPvhpkwE6UEZoRbGZa0aBlaMmAgAVEesA= Date: Mon, 5 Sep 2016 07:32:21 +0000 Message-ID: <22498D53301C4D4A8FFA8F02C7C3C7C06DDD7D42@mail02.WHT.local> References: <1470219398-10892-1-git-send-email-hn.chen@weidahitech.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.10.149] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u857X5Nm029036 Hi Dmitry, >> Considering to be compatible with i2c-hid, WDT8752 has the same way in >> enumerating device. >If it is a HID device then I think you should write a HID driver for it (unless existing driver, such as hid-multitouch can already handle it, possibly >with some changes). I'm addng Benjamin to he can comment as well. The device can be handled by i2c-hid driver (HID over I2C) already but this proprietary driver still is a must-have for more features. >> And also modify the part of FW update to be more efficiency. The main >> modification is that reducing the amount of data transmitted and using >> polling for time comsuming operation. >> >> Flash erase will wait 50ms for the operation complete in last driver. >> Extend it to 200ms since the spec says the typical is 30ms but the max >> is 200ms. >This should be split into a separate patch please. Ok, I will resubmit the part of possible-issue fixing and then the driver patch for supporting WDT8752 again. Please ignore this submission. Hn.chen