From: Max Staudt <max@enpas.org>
To: Jiri Kosina <jikos@kernel.org>,
Roderick Colenbrander <thunderbird2k@gmail.com>
Cc: Roderick Colenbrander <roderick.colenbrander@sony.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
nathaniel.lewis@sony.com
Subject: Re: [PATCH v2] hid-playstation: DS4: Update rumble and lightbar together
Date: Mon, 19 Aug 2024 23:02:34 +0200 [thread overview]
Message-ID: <224add74-501d-4db4-8e51-da6f30beffd1@enpas.org> (raw)
In-Reply-To: <nycvar.YFH.7.76.2408192246220.12664@cbobk.fhfr.pm>
On 8/19/24 22:46, Jiri Kosina wrote:
> On Mon, 19 Aug 2024, Roderick Colenbrander wrote:
>
>>>> Hi Max,
>>>>
>>>> That looks like a reasonable workaround. I think it would be fine to
>>>> add. We will try to support that with Android as well.
>>>
>>> Roderick, can I take this as your Acked-by:?
>>
>> Consider it Acked-by.
>
> Thanks. I was ->.<- this close to applying it, but apparently it's missing
> Max's signoff ...
Indeed it does, sorry.
I just got my hands on a few more controllers - let me send a PATCHv3
with the new findings :)
Sorry again for the back and forth, and for not finding earlier that
there may indeed be a pattern by which to tell controllers apart.
While most controllers copy the original HID descriptor exactly, the
controllers that need this patch seem to have something unique. I just
didn't think this would possibly be the case before.
Max
prev parent reply other threads:[~2024-08-19 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 13:09 Max Staudt
2024-08-14 16:17 ` Roderick Colenbrander
2024-08-14 16:40 ` Max Staudt
2024-08-14 16:53 ` Max Staudt
2024-08-19 18:33 ` Jiri Kosina
2024-08-19 20:37 ` Roderick Colenbrander
2024-08-19 20:46 ` Jiri Kosina
2024-08-19 21:02 ` Max Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224add74-501d-4db4-8e51-da6f30beffd1@enpas.org \
--to=max@enpas.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathaniel.lewis@sony.com \
--cc=roderick.colenbrander@sony.com \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®