From: Joseph Hunkeler <jhunkeler@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc:amd:yp:Add OMEN by HP Gaming Laptop 16z-n000 to quirks
Date: Thu, 16 Feb 2023 16:25:45 -0500 [thread overview]
Message-ID: <224b230c5c8d3037b650602b5743bbf217369ecb.camel@gmail.com> (raw)
In-Reply-To: <Y+5Ym5rUWLK4TOAf@sirena.org.uk>
On Thu, 2023-02-16 at 16:23 +0000, Mark Brown wrote:
> On Thu, Feb 16, 2023 at 10:50:07AM -0500, Joseph Hunkeler wrote:
> > Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Hi Mark,
I apologize, I don't fully understand what you're asking me to do. I see
the typo "yp:" was supposed to be "yc:". I took a quick look at a few other
submissions. Are you suggesting I change the email subject from:
> [PATCH] soc:amd:yp:Add OMEN by HP Gaming Laptop 16z-n000 to quirks
To something like:
"[PATCH] ASoC: amd: yc: Add OMEN by HP Gaming Laptop 16z-n000 to quirks table"?
If so, do I edit my original message as new, amend the subject, and resend
as-is? Or do I reply to the original message with the amended subject along
with the full contents of the patch body? I know you said there is no need
to resubmit to fix this, but it's is not clear to me how to do it without
resubmitting.
Thanks,
Joe
next prev parent reply other threads:[~2023-02-16 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 15:50 Joseph Hunkeler
2023-02-16 16:23 ` Mark Brown
2023-02-16 21:25 ` Joseph Hunkeler [this message]
2023-02-17 0:10 ` Mark Brown
2023-02-17 0:35 ` Joseph Hunkeler
2023-02-17 1:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224b230c5c8d3037b650602b5743bbf217369ecb.camel@gmail.com \
--to=jhunkeler@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®