Re: [PATCH v2 3/4] firewire: core: Prevent device_find_child() from modifying caller's match data

[Zijun Hu <zijun_hu@icloud.com>]

On 2024/8/21 22:29, Takashi Sakamoto wrote:
> Hi,
> 
> On Thu, Aug 15, 2024 at 10:58:04PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> To prepare for constifying the following old driver core API:
>>
>> struct device *device_find_child(struct device *dev, void *data,
>> 		int (*match)(struct device *dev, void *data));
>> to new:
>> struct device *device_find_child(struct device *dev, const void *data,
>> 		int (*match)(struct device *dev, const void *data));
>>
>> The new API does not allow its match function (*match)() to modify
>> caller's match data @*data, but lookup_existing_device() as the old
>> API's match function indeed modifies relevant match data, so it is not
>> suitable for the new API any more, fixed by implementing a equivalent
>> fw_device_find_child() instead of the old API usage.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>>  drivers/firewire/core-device.c | 37 +++++++++++++++++++++++++++++++++++--
>>  1 file changed, 35 insertions(+), 2 deletions(-)
> 
> Please drop this patch from your series since I applied another patch[1] to
> for-next branch.
> 

okay, let me declare [PATCH v2 3/4] are abandoned here now.

i will drop it from the next version patch series (^^).

> 
> [1] https://lore.kernel.org/r/20240820132132.28839-1-o-takashi@sakamocchi.jp
> 
> Thanks
> 
> Takashi Sakamoto