From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752428AbdBAUeP (ORCPT ); Wed, 1 Feb 2017 15:34:15 -0500 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752322AbdBAUeO (ORCPT ); Wed, 1 Feb 2017 15:34:14 -0500 Subject: Re: [PATCH] fscrypt: properly declare on-stack completion To: linux-fsdevel@vger.kernel.org References: <20170201203209.17710-1-richard@nod.at> Cc: linux-kernel@vger.kernel.org, jaegeuk@kernel.org, "Theodore Ts'o" , ebiggers@google.com, david@sigma-star.at From: Richard Weinberger Message-ID: <225430ef-9f08-bde3-4ad3-78d41b0464d2@nod.at> Date: Wed, 1 Feb 2017 21:34:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170201203209.17710-1-richard@nod.at> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.02.2017 um 21:32 schrieb Richard Weinberger: > When a completion is declared on-stack we have to use > COMPLETION_INITIALIZER_ONSTACK(). > > Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs > tree to fs/crypto") > Signed-off-by: Richard Weinberger > > --- > fs/crypto/fscrypt_private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h > index aeab032d7d35..a0494a164f97 100644 > --- a/fs/crypto/fscrypt_private.h > +++ b/fs/crypto/fscrypt_private.h > @@ -81,7 +81,7 @@ struct fscrypt_completion_result { > > #define DECLARE_FS_COMPLETION_RESULT(ecr) \ > struct fscrypt_completion_result ecr = { \ > - COMPLETION_INITIALIZER((ecr).completion), 0 } > + COMPLETION_INITIALIZER_ONSTACK((ecr).completion), 0 } > > > /* crypto.c */ > Replying with Ted's corrected mail address... ;-\ Thanks, //richard