From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651AbbIGXOh (ORCPT ); Mon, 7 Sep 2015 19:14:37 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:45667 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751135AbbIGXOf (ORCPT ); Mon, 7 Sep 2015 19:14:35 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, preeti.lkml@gmail.com, open list Subject: Re: [PATCH V2 1/9] cpufreq: Use __func__ to print function's name Date: Tue, 08 Sep 2015 01:42:23 +0200 Message-ID: <2255089.Zk01N0S7pW@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 27, 2015 05:58:06 PM Viresh Kumar wrote: > Its better to use __func__ to print functions name instead of writing > the name in the print statement. This also has the advantage that a > change in function's name doesn't force us to change the print message > as well. > > Reviewed-by: Preeti U Murthy > Signed-off-by: Viresh Kumar OK, this is simple enough. Applied, thanks! > --- > drivers/cpufreq/cpufreq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 46251e8d30f2..f620055279f3 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -2074,8 +2074,7 @@ static int __cpufreq_governor(struct cpufreq_policy *policy, > if (!try_module_get(policy->governor->owner)) > return -EINVAL; > > - pr_debug("__cpufreq_governor for CPU %u, event %u\n", > - policy->cpu, event); > + pr_debug("%s: for CPU %u, event %u\n", __func__, policy->cpu, event); > > mutex_lock(&cpufreq_governor_lock); > if ((policy->governor_enabled && event == CPUFREQ_GOV_START) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.