mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Morten Hein Tiljeset" <morten@tiljeset.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Debugging stuck mount
Date: Thu, 08 Aug 2024 11:40:07 +0200	[thread overview]
Message-ID: <22578d44-b822-40ff-87fb-e50b961fab15@app.fastmail.com> (raw)

Hi folks,

I'm trying to debug an issue that occurs sporadically in production where the
ext4 filesystem on a device, say dm-1, is never fully closed. This is visible
from userspace only via the existence of /sys/fs/ext4/dm-1 which cryptsetup
uses to determine that the device is still mounted.

My initial thought was that it was mounted in some mount namespace, but this is
not the case. I've used a debugger (drgn) on /proc/kcore to find the
superblock. I can see that this is kept alive by a single mount which looks
like this (leaving out all fields that are NULL/empty lists):

*(struct mount *)0xffff888af92c5cc0 = {
	.mnt_parent = (struct mount *)0xffff888af92c5cc0,
	.mnt_mountpoint = (struct dentry *)0xffff888850331980,  // an application defined path
	.mnt = (struct vfsmount){
		.mnt_root = (struct dentry *)0xffff888850331980,    // note: same path as path as mnt_mountpoint
		.mnt_sb = (struct super_block *)0xffff88a89f7bc800, // points to the superblock I want cleaned up
		.mnt_flags = (int)134217760,                        // 0x8000020 = MNT_UMOUNT | MNT_RELATIME
		.mnt_userns = (struct user_namespace *)init_user_ns+0x0 = 0xffffffffb384b400,
	},
	.mnt_pcp = (struct mnt_pcp *)0x37dfbfa2c338,
	.mnt_instance = (struct list_head){
		.next = (struct list_head *)0xffff88a89f7bc8d0,
		.prev = (struct list_head *)0xffff88a89f7bc8d0,
	},
	.mnt_devname = (const char *)0xffff88a7d0fe7cc0 = "/dev/mapper/<my device>_crypt", // maps to /dev/dm-1
	.mnt_id = (int)3605,
}

In particular I notice that the mount namespace is NULL. As far as I understand
the only way to get this state is through a lazy unmount (MNT_DETACH). I can at
least manage to create a similar state by lazily unmounting but keeping the
mount alive with a shell with CWD inside the mountpoint.

I've tried to search for the superblock pointer on cwd/root of all tasks, which
works in my synthetic example but not for the real case. I've had similar
results searching for the superblock pointer using drgn's fsrefs.py script[1]
which has support for searching additional kernel data structures.

Is there any good way of detecting why this mount is kept alive? Where am I not
looking? Any pointers would be greatly appreciated!

[1] https://drgn.readthedocs.io/en/latest/release_highlights/0.0.26.html

             reply	other threads:[~2024-08-08  9:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08  9:40 Morten Hein Tiljeset [this message]
2024-08-08 12:32 ` Christian Brauner
2024-08-08 14:20   ` Morten Hein Tiljeset
2024-08-08 14:58     ` Christian Brauner
2024-08-09  7:39       ` Morten Hein Tiljeset
2024-08-09 12:41         ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22578d44-b822-40ff-87fb-e50b961fab15@app.fastmail.com \
    --to=morten@tiljeset.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®