From: Conor Dooley <conor@kernel.org>
To: Hal Feng <hal.feng@starfivetech.com>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties of S7 core
Date: Fri, 24 Mar 2023 19:05:34 +0000 [thread overview]
Message-ID: <225945e3-2610-4fec-8ee5-5893d26641b4@spud> (raw)
In-Reply-To: <20230324064651.84670-1-hal.feng@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]
On Fri, Mar 24, 2023 at 02:46:51PM +0800, Hal Feng wrote:
> The S7 core has no L1 data cache and MMU, so delete some
> related properties.
>
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
>
> Hi, Conor,
>
> This is a correction for the S7 entry.
Again going off the latest version of the u74-mc core complex, this
looks to be correct, thanks.
I need to go read the Emil email from earier today, but I've
provisionally gone and put this on the riscv-jh7100_initial_dts branch
with a Fixes: tag.
Thanks,
Conor.
> This patch depends on patch [1].
>
> [1] https://lore.kernel.org/all/20230320103750.60295-20-hal.feng@starfivetech.com/
>
> ---
> arch/riscv/boot/dts/starfive/jh7110.dtsi | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index d484ecdf93f7..4c5fdb905da8 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -20,21 +20,12 @@ cpus {
> S7_0: cpu@0 {
> compatible = "sifive,s7", "riscv";
> reg = <0>;
> - d-cache-block-size = <64>;
> - d-cache-sets = <64>;
> - d-cache-size = <8192>;
> - d-tlb-sets = <1>;
> - d-tlb-size = <40>;
> device_type = "cpu";
> i-cache-block-size = <64>;
> i-cache-sets = <64>;
> i-cache-size = <16384>;
> - i-tlb-sets = <1>;
> - i-tlb-size = <40>;
> - mmu-type = "riscv,sv39";
> next-level-cache = <&ccache>;
> riscv,isa = "rv64imac_zba_zbb";
> - tlb-split;
> status = "disabled";
>
> cpu0_intc: interrupt-controller {
> --
> 2.38.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-03-24 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 6:46 Hal Feng
2023-03-24 19:05 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225945e3-2610-4fec-8ee5-5893d26641b4@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®