Re: [PATCH v8 char-misc-next 5/5] misc: microchip: pci1xxxx: Add documentation for sysfs bin attributes

[<VaibhaavRam.TL@microchip.com>]

On Wed, 2023-03-29 at 12:03 +0200, Greg KH wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Tue, Mar 28, 2023 at 08:10:08PM +0530, Vaibhaav Ram T.L wrote:
> > From: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> > 
> > This patch contains Documentation for Microchip PCI1XXXX OTP/EEPROM
> > sysfs
> > bin attributes.
> > 
> > Co-developed-by: Tharun Kumar P
> > <tharunkumar.pasumarthi@microchip.com>
> > Signed-off-by: Tharun Kumar P
> > <tharunkumar.pasumarthi@microchip.com>
> > Signed-off-by: Kumaravel Thiagarajan
> > <kumaravel.thiagarajan@microchip.com>
> > Signed-off-by: Vaibhaav Ram T.L <vaibhaavram.tl@microchip.com>
> > ---
> >  Documentation/ABI/stable/sysfs-devices-mchp-pci1xxxx | 11
> > +++++++++++
> >  1 file changed, 11 insertions(+)
> >  create mode 100644 Documentation/ABI/stable/sysfs-devices-mchp-
> > pci1xxxx
> > 
> > diff --git a/Documentation/ABI/stable/sysfs-devices-mchp-pci1xxxx
> > b/Documentation/ABI/stable/sysfs-devices-mchp-pci1xxxx
> > new file mode 100644
> > index 000000000000..0913c7b01990
> > --- /dev/null
> > +++ b/Documentation/ABI/stable/sysfs-devices-mchp-pci1xxxx
> > @@ -0,0 +1,11 @@
> > +What:               
> > /sys/devices/pciXXXX:XX/XXXX:XX:XX.X/../mchp_pci1xxxx_gp.gp_otp_e2p
> > .n/pci1xxxx_eeprom
> > +Date:                March 27, 2023
> > +KernelVersion:       6.3
> > +Contact:     Vaibhaav Ram T.L <vaibhaavram.tl@microchip.com>
> > +Description: This bin file is used for writing into and reading
> > from Microchip PCI1XXXX EEPROM
> 
> "bin"?  Userspace doesn't know what that means.
Can I replace with "files"?
> 
> But again, why can't you use the eeprom api instead?
This is explained in other replies - this eeprom/otp is not accessible
through any i2c/SPI bus available to kernel.


Thank You.

Regards,
Vaibhaav Ram