From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424704AbdEYRSR (ORCPT ); Thu, 25 May 2017 13:18:17 -0400 Received: from mout.web.de ([212.227.15.3]:54690 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031883AbdEYRSO (ORCPT ); Thu, 25 May 2017 13:18:14 -0400 To: linux-s390@vger.kernel.org, Heiko Carstens , Martin Schwidefsky , Paul Gortmaker Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] s390: kernel: Delete an error message for a failed memory allocation in cpcmd() Message-ID: <225c2a55-eb6e-35cb-285a-cb664a34bc7e@users.sourceforge.net> Date: Thu, 25 May 2017 19:18:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YluRI45+v1d/GX/y014ub4R3dPs9VCYSCoM/kpaHo77+ztdtR7C MvSPdE6ryR1zM9BU2HqmxN3bOKfEG8+BiR4AsiG+TCprDf5WWUSR+Ao5CRqsfEOF49og0sz IzgW+4c4WFrGgZW7l7BfhJQnvtVwd5lLJTTeBYGaAIGSpWOOyua3cymk0/h+5vtOYlO1+Xl j3pM1zr5/insgBNwIJ1tg== X-UI-Out-Filterresults: notjunk:1;V01:K0:4wxHWy0muwo=:JWmvtXiVC2zU56XlE2oGM3 IwSECcxMgHxVAQMq6hLYhFbHFQZ1G+vRW1pxKRNBW85JMixz9IpFsUHi8epQPBR6VE05Y0be1 WfAgL/8vXxoAmzvm//6JT2gunhLoGin8zzyDsOs1bwOI3cB285+reFGZK9NNl1eCOIbPAcVeX yX6tatiQeWpEATYAW3mbnDbQKumiY8jcWPi5WisfqKmBri0lwRavi37U1PDzhXec+3kc1c6Dp Eybn/s9qkzm2HvjD0Ti3Jl8Lz4+1Fc006DGW+jSbmCqYybgUwVM9PiBIfHd0noZXK8B48a4JX Jle8BkN9K9J9SIMWIvXVlhFF1OOjQYkomxkORqOC4uJzJUXaEDS4W5UhNILr0me/WsWKFMnQA SZvzf8C7lVeC8w6bMy9ATGAqRdXvO4vf/JDLaox+T1bpZCX92Er+9o2JiPZiDXGOA4EBaCYN8 PQIyXZmkyLHf+hz61gNeZR7WD7vW2bfk/R4AhspCHSVvk1uCQ9YoXSOZ3SI319eFaPNQMOcds XU9quNCgSAsf+Jp1Ms+ShSUlfkJ0N+5jGSBkhjnUxQnArnRq3EqNVhlZXIBVjgt97RvW8Gx5L eLyf0MVtrA6YzQ/kwC4slyUx4vl1wM0Po95qA4OjBWhXOZHplceX+fnt6+nh+kg0twRd5hR16 PgEZRxF44h9wrYqUWSwW2f9iufAoWQ34cHQuh1EUunaRl6rqSQ4KrIpCvFxdwtLoVxbgygqfp DprvH2t6Q4uNZ4yrLAj1O+gleMW6TAuA4+3msmuQoFoSgt8meV20a4He17EeiXq4HjMhOnse6 IoOab+m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 May 2017 19:09:50 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/s390/kernel/cpcmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/s390/kernel/cpcmd.c b/arch/s390/kernel/cpcmd.c index 9f0e4a2785f7..2f9c97813846 100644 --- a/arch/s390/kernel/cpcmd.c +++ b/arch/s390/kernel/cpcmd.c @@ -95,10 +95,9 @@ int cpcmd(const char *cmd, char *response, int rlen, int *response_code) if ((virt_to_phys(response) != (unsigned long) response) || (((unsigned long)response + rlen) >> 31)) { lowbuf = kmalloc(rlen, GFP_KERNEL | GFP_DMA); - if (!lowbuf) { - pr_warn("The cpcmd kernel function failed to allocate a response buffer\n"); + if (!lowbuf) return -ENOMEM; - } + spin_lock_irqsave(&cpcmd_lock, flags); len = __cpcmd(cmd, lowbuf, rlen, response_code); spin_unlock_irqrestore(&cpcmd_lock, flags); -- 2.13.0