From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DEA282C08D1 for ; Thu, 22 Jan 2026 07:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769065492; cv=none; b=YIK1lFqAdHrYQ4i9vYJkGApXCx8Zc8pWFKGGcl1ziJTRM/BP9s2JScQFDOl7v4VZs+KSef11cj1qQ9ijEE2cTG1BSxcqu3+5nOyPb0EezRMIm2YAMzdPYvXEyMfRnCdo5axf9Ctmn2NBv4+j4Wptyet8KeqI7iZnLoN7udvAbww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769065492; c=relaxed/simple; bh=Kbzu7S4L+S/Fd4zuWamNvIzf0kNbSFinMyzp4qqD5Co=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s7AKuzX+t192aNa3jvwLnU9qWlrpxIZr52FDsmTIap2M3ZuDqAyIbcAN8vDb9bIUgAq3UAqOKOWYaG2p/HOSRA9H2S+b4+0E6MUbftqIXBQIZyYimr8kBbRBLG/FkylqBu8U01OhFi+7JDH1wehgrn7VqBlU81TKcqxHaTHowO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC5A61476; Wed, 21 Jan 2026 23:04:32 -0800 (PST) Received: from [10.164.18.63] (MacBook-Pro.blr.arm.com [10.164.18.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1B633F632; Wed, 21 Jan 2026 23:04:35 -0800 (PST) Message-ID: <225e9943-4e7d-48c6-83b9-98284fa31092@arm.com> Date: Thu, 22 Jan 2026 12:34:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 1/5] mm/khugepaged: remove unnecessary goto 'skip' label To: Shivank Garg , Andrew Morton , David Hildenbrand , Lorenzo Stoakes Cc: Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260118192253.9263-4-shivankg@amd.com> <20260118192253.9263-6-shivankg@amd.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260118192253.9263-6-shivankg@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/01/26 12:52 am, Shivank Garg wrote: > Replace goto skip with actual logic for better code readability. > > No functional change. > > Reviewed-by: Liam R. Howlett > Reviewed-by: Zi Yan > Acked-by: David Hildenbrand (Red Hat) > Reviewed-by: Lance Yang > Signed-off-by: Shivank Garg LGTM Reviewed-by: Dev Jain > --- > mm/khugepaged.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 16582bdcb6ff..984294a16861 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2442,14 +2442,15 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, > break; > } > if (!thp_vma_allowable_order(vma, vma->vm_flags, TVA_KHUGEPAGED, PMD_ORDER)) { > -skip: > progress++; > continue; > } > hstart = round_up(vma->vm_start, HPAGE_PMD_SIZE); > hend = round_down(vma->vm_end, HPAGE_PMD_SIZE); > - if (khugepaged_scan.address > hend) > - goto skip; > + if (khugepaged_scan.address > hend) { > + progress++; > + continue; > + } > if (khugepaged_scan.address < hstart) > khugepaged_scan.address = hstart; > VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK);