From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C144EC433DB for ; Mon, 18 Jan 2021 20:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B1A422CAD for ; Mon, 18 Jan 2021 20:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390447AbhARUdA (ORCPT ); Mon, 18 Jan 2021 15:33:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54218 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728333AbhARUcI (ORCPT ); Mon, 18 Jan 2021 15:32:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611001841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yqbvFErNC41ofhFoCIqH0jJ0VT1UHbY55ftD8sHsSmY=; b=GJPqvvfJS9PeRZjALbxpiEJmxL1qrJ0Lvyb3qqsnqAuhlpr7AGawqzar/2eoZKGIZcCLqG dUvWL719SdduX1OeWZvmCrVicQg7ClaJ0lJHJ3lujJKRz8xmDG/ZOLQpzSgcSm60MLLG1l 5mRGQ1+O89UExil0ckkSzGtnBXxs2Qg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-GrhyNGU-OWeaQZ11vqrUgw-1; Mon, 18 Jan 2021 15:30:39 -0500 X-MC-Unique: GrhyNGU-OWeaQZ11vqrUgw-1 Received: by mail-ed1-f69.google.com with SMTP id y6so6433695edc.17 for ; Mon, 18 Jan 2021 12:30:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yqbvFErNC41ofhFoCIqH0jJ0VT1UHbY55ftD8sHsSmY=; b=Hv6xuPL/kG8MXyJ6wumQkxQbb5jALAxsxifmL+08rlnmv5AzPVd3KwKTw9peJ1Ja3V n3GGznKuiDrsyD48fYY7aKANQv9Iv52S0N0wW4HDruaZNG7+ycclVLIQ51KrvJh/sYcV A+2nyY5NxRnjW+j34l9kWemnY12lwAa744J1LwSS/UqOF7WWAeQCHJ4oruriorG+d6hs xLGQlPkNEeVd01D2m1M93MNKoLydwWHhdi0QOdxhVDXzK7OA/fUIInFYKY/AQC0GTVf/ L2wuS+gPF3cxvmQ9meSVaXTbdwCu2eaqP8Jwh3P8iRES7p1cI313rJMUdsXRSiechc8z ZLmw== X-Gm-Message-State: AOAM530kY7rTt4z6vvyzxBIyyUCpciQfHXbmSXJBkjxg/w03rgiQvvTN L+O9nJvfCCEm7Q1fMHFhHcqeWWpDAvr5f6waPZ4KeZe3eJ6a6rQqIa0E1lnFfUUNRPGLaSmO+Ye 3rhtKOc2FmjXlQPU8UL4vxnvP X-Received: by 2002:a17:906:f988:: with SMTP id li8mr953191ejb.84.1611001837771; Mon, 18 Jan 2021 12:30:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxg5krC67ubd8S/V4gd8xzdojPqRghoeT2iGz9bOd2FzH0hKKFUekA32nKlrNmtiIL8GX9RnQ== X-Received: by 2002:a17:906:f988:: with SMTP id li8mr953172ejb.84.1611001837533; Mon, 18 Jan 2021 12:30:37 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id a22sm8077675edv.67.2021.01.18.12.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 12:30:36 -0800 (PST) Subject: Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including SEV-ES support To: Borislav Petkov Cc: Sean Christopherson , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Andy Lutomirski , Dave Hansen , Peter Zijlstra , "H. Peter Anvin" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Brijesh Singh References: <20210116002517.548769-1-seanjc@google.com> <20210118202611.GH30090@zn.tnic> From: Paolo Bonzini Message-ID: <2262feb0-830e-1e05-d81b-031d54cf6853@redhat.com> Date: Mon, 18 Jan 2021 21:30:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118202611.GH30090@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/21 21:26, Borislav Petkov wrote: > On Mon, Jan 18, 2021 at 06:59:38PM +0100, Paolo Bonzini wrote: >> On 16/01/21 01:25, Sean Christopherson wrote: >>> >>> @@ -1527,12 +1527,14 @@ config AMD_MEM_ENCRYPT >>> select DYNAMIC_PHYSICAL_MASK >>> select ARCH_USE_MEMREMAP_PROT >>> select ARCH_HAS_FORCE_DMA_UNENCRYPTED >>> - select INSTRUCTION_DECODER >>> help >>> Say yes to enable support for the encryption of system memory. >>> This requires an AMD processor that supports Secure Memory >>> Encryption (SME). >>> + This also enables support for running as a Secure Encrypted >>> + Virtualization (SEV) guest. >>> + >>> config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT >>> bool "Activate AMD Secure Memory Encryption (SME) by default" >>> default y >>> @@ -1547,6 +1549,15 @@ config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT >>> If set to N, then the encryption of system memory can be >>> activated with the mem_encrypt=on command line option. >>> +config AMD_SEV_ES_GUEST >>> + bool "AMD Secure Encrypted Virtualization - Encrypted State (SEV-ES) Guest support" >>> + depends on AMD_MEM_ENCRYPT >>> + select INSTRUCTION_DECODER >>> + help >>> + Enable support for running as a Secure Encrypted Virtualization - >>> + Encrypted State (SEV-ES) Guest. This enables SEV-ES boot protocol >>> + changes, #VC handling, SEV-ES specific hypercalls, etc... >>> + >> >> Queued, thanks. > > Say, Paolo, why are you queuing a patch which goes through tip, if at all? Right you are, unqueued. I would have caught the mistake before actually crystallizing the hashes, but thanks for noticing! Sean, please send a v2 that removes the help change for AMD_MEM_ENCRYPT, too. Thanks, Paolo