From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753105AbbCHWtI (ORCPT <rfc822;w@1wt.eu>);
	Sun, 8 Mar 2015 18:49:08 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:58591 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752361AbbCHWtG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 8 Mar 2015 18:49:06 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Aleksey Makarov <aleksey.makarov@auriga.com>
Cc: linux-ide@vger.kernel.org, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>,
        Vinita Gupta <vgupta@caviumnetworks.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Tejun Heo <tj@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] SATA: OCTEON: support SATA on OCTEON platform
Date: Sun, 08 Mar 2015 23:48:21 +0100
Message-ID: <2264145.MknHxHLvY7@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1425567540-31572-1-git-send-email-aleksey.makarov@auriga.com>
References: <1425567540-31572-1-git-send-email-aleksey.makarov@auriga.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:qfmyRC6L0a+OVHROUVCDYK30Y81hwF09fF1QiGxB/WT1XKM+a+t
 fZjP8WsO3VIRabsTf0pnmt98KyJikU6Wnwd334p6PaGbdJcDIfsV823mcWu1hbj9W4U78/H
 dMQHNh/NvAG+pIs8miSqqJ0PL6PJSIOJybTcUSUGs9WwjkuPFmpQtOzTbX6txtWbLtNrNxT
 m2XG6CP72GbftYhaCnnYg==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 05 March 2015 17:58:58 Aleksey Makarov wrote:
> +       ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
> +       if (ret)
> +               return ret;
> 

Don't do this, instead you should set the dma-ranges of the parent
bus correctly so that dma_set_mask_and_coherent succeeds.

dma_coerce_mask_and_coherent() was introduced as a hack to
annotate broken drivers that were overriding the dma_mask pointer
themselves.

	Arnd