From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933342AbbIYVMU (ORCPT ); Fri, 25 Sep 2015 17:12:20 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:43406 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933215AbbIYVMS (ORCPT ); Fri, 25 Sep 2015 17:12:18 -0400 From: "Rafael J. Wysocki" To: Stephen Boyd Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, Greg Kroah-Hartman , Len Brown , open list , Pavel Machek Subject: Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors Date: Fri, 25 Sep 2015 23:40:33 +0200 Message-ID: <2265537.PORMnUrJPF@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150922165127.GH23081@codeaurora.org> References: <3ad0ce115028e628e556a505689d396b6e98f04e.1442939340.git.viresh.kumar@linaro.org> <20150922165127.GH23081@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 22, 2015 09:51:27 AM Stephen Boyd wrote: > On 09/22, Viresh Kumar wrote: > > of_property_count_u32_elems() will never return 0, but a -ve error value > > of a positive count. And so the current !count check is wrong. > > > > Also, a missing "opp-microvolt" property isn't a problem and so we need > > to do of_find_property() separately to confirm that. > > > > Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings") > > Signed-off-by: Viresh Kumar > > --- > > Reviewed-by: Stephen Boyd Applied, thanks! Rafael