From: Helen Koike <koike@igalia.com>
To: Vignesh Raman <vignesh.raman@collabora.com>,
dri-devel@lists.freedesktop.org
Cc: daniels@collabora.com, daniel@fooishbar.org,
helen.fornazier@gmail.com, airlied@gmail.com,
simona.vetter@ffwll.ch, robdclark@gmail.com,
guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
valentine.burley@collabora.com, lumag@kernel.org,
quic_abhinavk@quicinc.com, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests
Date: Thu, 10 Apr 2025 11:40:32 -0300 [thread overview]
Message-ID: <2266002e-372d-434c-a2f5-282166e28c70@igalia.com> (raw)
In-Reply-To: <a16c70e0-9078-4a21-9fa1-ca9d33823ff2@collabora.com>
On 10/04/2025 05:07, Vignesh Raman wrote:
> Hi Helen,
>
> On 09/04/25 23:53, Helen Koike wrote:
>> Hi Vignesh,
>>
>> Thank you for your patch.
>>
>> On 09/04/2025 03:15, Vignesh Raman wrote:
>>> Add jobs to validate devicetrees and run KUnit tests.
>>>
>>> Pipeline link,
>>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550
>>
>> I see the checks are in the same stage as build, does it make sense to
>> create another stage? Similar to what was proposed on kci-gitlab?
>>
>> Also, I don't think it make sense for kunit to be in the build stage.
>> Maybe in software-driver? Since kunit runs on a qemu.
>
> We can add a `test` stage for kunit and a `static-checks` stage for
> devicetree validation and check patch. What do you think?
Ack on static-checks stage.
`test` stage confuses me, because all the other stages with driver names
are also tests, this is why I suggested to move to `software-driver`.
Or maybe we could just have a kunit stage for now.
Helen
>
> Regards,
> Vignesh
>
>>
>> Helen
>>
>>>
>>> Link to v1,
>>> https://lore.kernel.org/all/20250327160117.945165-1-
>>> vignesh.raman@collabora.com/
>>>
>>> Vignesh Raman (2):
>>> drm/ci: Add jobs to validate devicetrees
>>> drm/ci: Add jobs to run KUnit tests
>>>
>>> drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
>>> drivers/gpu/drm/ci/dt-binding-check.sh | 16 +++++++++
>>> drivers/gpu/drm/ci/dtbs-check.sh | 19 +++++++++++
>>> drivers/gpu/drm/ci/gitlab-ci.yml | 2 ++
>>> drivers/gpu/drm/ci/kunit.sh | 11 ++++++
>>> drivers/gpu/drm/ci/kunit.yml | 32 ++++++++++++++++++
>>> 6 files changed, 123 insertions(+)
>>> create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>>> create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>>> create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>>> create mode 100755 drivers/gpu/drm/ci/kunit.sh
>>> create mode 100644 drivers/gpu/drm/ci/kunit.yml
>>>
>>
>
next prev parent reply other threads:[~2025-04-10 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 6:15 Vignesh Raman
2025-04-09 6:15 ` [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees Vignesh Raman
2025-04-09 9:53 ` Maxime Ripard
2025-04-10 19:32 ` Dmitry Baryshkov
2025-04-11 8:32 ` Vignesh Raman
2025-04-11 9:58 ` Dmitry Baryshkov
2025-04-09 6:15 ` [PATCH v2 2/2] drm/ci: Add jobs to run KUnit tests Vignesh Raman
2025-04-09 9:53 ` Maxime Ripard
2025-04-09 18:23 ` [PATCH v2 0/2] drm/ci: Add devicetree validation and " Helen Koike
2025-04-10 8:07 ` Vignesh Raman
2025-04-10 14:40 ` Helen Koike [this message]
2025-04-11 8:35 ` Vignesh Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2266002e-372d-434c-a2f5-282166e28c70@igalia.com \
--to=koike@igalia.com \
--cc=airlied@gmail.com \
--cc=daniel@fooishbar.org \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guilherme.gallo@collabora.com \
--cc=helen.fornazier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sergi.blanch.torne@collabora.com \
--cc=simona.vetter@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=valentine.burley@collabora.com \
--cc=vignesh.raman@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®