From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B32CC48BCF for ; Wed, 9 Jun 2021 12:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E3E661285 for ; Wed, 9 Jun 2021 12:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235191AbhFIMPM (ORCPT ); Wed, 9 Jun 2021 08:15:12 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:5470 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbhFIMPG (ORCPT ); Wed, 9 Jun 2021 08:15:06 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G0Qsk46w6zZds7; Wed, 9 Jun 2021 20:10:18 +0800 (CST) Received: from dggema761-chm.china.huawei.com (10.1.198.203) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 20:13:08 +0800 Received: from [10.174.178.46] (10.174.178.46) by dggema761-chm.china.huawei.com (10.1.198.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 9 Jun 2021 20:13:08 +0800 Subject: Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe() To: , , CC: , , , , References: <20210601082454.127810-1-chengzhihao1@huawei.com> From: Zhihao Cheng Message-ID: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com> Date: Wed, 9 Jun 2021 20:13:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20210601082454.127810-1-chengzhihao1@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggema761-chm.china.huawei.com (10.1.198.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/6/1 16:24, Zhihao Cheng дµÀ: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: Zhihao Cheng > --- > drivers/mailbox/bcm2835-mailbox.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c > index 39761d190545..86b7ce3549c5 100644 > --- a/drivers/mailbox/bcm2835-mailbox.c > +++ b/drivers/mailbox/bcm2835-mailbox.c > @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev) > mbox->regs = devm_ioremap_resource(&pdev->dev, iomem); > if (IS_ERR(mbox->regs)) { > ret = PTR_ERR(mbox->regs); > - dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret); > return ret; > } > friendly ping.