From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB051C77B7A for ; Wed, 7 Jun 2023 15:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240770AbjFGPNc (ORCPT ); Wed, 7 Jun 2023 11:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240202AbjFGPN2 (ORCPT ); Wed, 7 Jun 2023 11:13:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 229D11FD8 for ; Wed, 7 Jun 2023 08:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686150752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K3r/K8HkhE4xuB+jM5Kf0f4GFwH3PwislIM7Zb9RO88=; b=Kx/olDY7n+AR/mWIm3hZiRU0lk9Jhy8V3t2KtoG7v4MYsePw9bNbx41HRVONKQKKHhe6al vRXWWUGYk7Lu7Iryo4M8e44M1vKpusF0bqmQMsQ67FCp3KM33EKCq5waNucshwXPgMff6R WZ7vpjsCfALiead2nDZwLipB3+y0s5A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-641-v6-IUeUzMTyM9FIOsecLMw-1; Wed, 07 Jun 2023 11:12:28 -0400 X-MC-Unique: v6-IUeUzMTyM9FIOsecLMw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93FE0848B6F; Wed, 7 Jun 2023 15:03:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id C69F82166B25; Wed, 7 Jun 2023 15:03:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> To: Tariq Toukan Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2267271.1686150217.1@warthog.procyon.org.uk> Date: Wed, 07 Jun 2023 16:03:37 +0100 Message-ID: <2267272.1686150217@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tariq Toukan wrote: > My team spotted a new degradation in TLS TX device offload, bisected to this > patch. I presume you're using some hardware (I'm guessing Mellanox?) that can actually do TLS offload? Unfortunately, I don't have any hardware that can do this, so I can't test the tls_device stuff. > From a quick look at the patch, it's not clear to me what's going wrong. > Please let us know of any helpful information that we can provide to help in > the debug. Can you find out what source line this corresponds to? RIP: 0010:skb_splice_from_iter+0x102/0x300 Assuming you're building your own kernel, something like the following might do the trick: echo "RIP: 0010:skb_splice_from_iter+0x102/0x300" | ./scripts/decode_stacktrace.sh /my/built/vmlinux /my/build/tree if you run it in the kernel source tree you're using and substitute the paths to vmlinux and the build tree for modules. David