From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD65C54E76 for ; Thu, 5 Jan 2023 09:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232003AbjAEJqv (ORCPT ); Thu, 5 Jan 2023 04:46:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231977AbjAEJqq (ORCPT ); Thu, 5 Jan 2023 04:46:46 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3A14568A7; Thu, 5 Jan 2023 01:46:31 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1680332009EC; Thu, 5 Jan 2023 04:46:30 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Thu, 05 Jan 2023 04:46:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1672911989; x=1672998389; bh=Re eVYXXoQmzg71a3dadwFOkrgyrpB9RqBRBioW6WdJs=; b=I2317b/qhr65GwM/6z vChVLjQhL10Ejzw8xfejgdexJTug92mRZ+vsQwnQv3r3NDYRM41y3Dwg/WCa3vPv b1hofr6VFaQQBuQbXkc4WMuEGrcwSOoC8iItbsisxPzjMSXvzsJoAbpayTzjU/Su JBnnOXkjiFvjbnDYtarqMLzWG6dmZWprYg325fR8v8WDfdbqmaOrGLOdJb+YU2Kb cH5GpG8dLJh9YaG8VaLrCXA2pMQmo04n10q4mDd3xRojSpvSVmuUjPFhWUq9gr0D MEcI6i+FLTNlPwI97rzZWLjzZMs4SwPtWweBBILP3a/eutnD02fkbdz17DHEPFzZ djCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672911989; x=1672998389; bh=ReeVYXXoQmzg71a3dadwFOkrgyrp B9RqBRBioW6WdJs=; b=XEck3zsX/E54i904WdfhmloqKiUKZ33P8zLL0aMEDui4 Yf6RRO1E/c6etJ+W6CwPrLvEoeHJ1zCgdKMTqluhi6r2L/Iv8pnaJDY03zH6WcnG tmvSnZHlGkI5BIzVh3L54Pm099Veo1b4qG5OLX3wCevlC9LpWkXy/E9edgfalZTu oTSdCEq9wQdX+OLytu4TwiMUNU2kdwQH90w6pfFXmA3168m3teyr4lQN9JZzdMOk PHwWHglh4KL2kn2ctt1L7kJr8L+YHygdKxYJP5YZGGTZEApnggqUA6wqijGi+mFU r6XuP+KsQr7DE5QSDIBw2gRqjf9103HIly7HB1Fhvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeekgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfuvhgv nhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrg htthgvrhhnpeelvefggeffheevtdeivefhkeehfeettdejteduveeiheevveeilefghfei veeiueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsvhgvnhesshhvvghnphgvthgvrhdruggvvh X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6F1C3A6007C; Thu, 5 Jan 2023 04:46:29 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <2267ef84-a167-4cd6-86fd-725e064eae62@app.fastmail.com> In-Reply-To: <57a52e19-e121-6082-a4d8-f58ade353782@marcan.st> References: <20230104110013.24738-1-marcan@marcan.st> <20230104110013.24738-7-marcan@marcan.st> <228a80d4-752b-42ae-84b4-47197ec82c24@app.fastmail.com> <57a52e19-e121-6082-a4d8-f58ade353782@marcan.st> Date: Thu, 05 Jan 2023 10:46:09 +0100 From: "Sven Peter" To: "Hector Martin" , "Joerg Roedel" , "Will Deacon" , "Robin Murphy" Cc: "Alyssa Rosenzweig" , "Janne Grunau" , "Rob Herring" , "Krzysztof Kozlowski" , devicetree@vger.kernel.org, iommu@lists.linux.dev, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] iommu: dart: Support different variants with different registers Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jan 5, 2023, at 06:16, Hector Martin wrote: > On 2023/01/04 22:43, Sven Peter wrote: >> On Wed, Jan 4, 2023, at 12:00, Hector Martin wrote: >>> + u64 enable_streams; >>> + u64 disable_streams; >> I don't think disable_streams is used anywhere. I assume you just left it in >> here to document it? > > Yeah, we don't use this field ever, so we might as well drop it. I'll > leave the #define for T8110 in though, as documentation. > >>> + u64 ttbr; >>> + u64 ttbr_valid; >>> + u64 ttbr_addr_off; >> >> This name confused me a bit since off sounds like offset to me while >> this is actually another shift. Can't really think of a better name >> right now though. I'd at least a comment here to describe it. > > How about `ttbr_addr_field_shift`? Sounds good to me! Sven