From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6BE43101B0 for ; Thu, 18 Jun 2026 12:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781786197; cv=none; b=u4uKZb9wWMcmt27rcOWTDcWy1a0lp21TRzSe4rsnzi4GWWUrrkGRTue3Dgy87qEZye7CPhfC3GcWqo8GwEf7K5dX2fYET8dO9hrFZHQHdtaCIKyN/bR8XfjGbtRlG98jO4bcFB4y3+SVJ2JxxqMUh08Oxs/V4OYQHwIXl7GL3+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781786197; c=relaxed/simple; bh=K+0x3UrBGShhz8wCrdR54NiTLNqYO3w0UTI1bSEaIM8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R/AjKnVGtbhgnLB7sH9nQ4HX7RjqiH2lsiPVft1KaL91X2oVUyC5BIduW2Km+6bdXsLAWEBsoH4OBuVQOaNe/cwJAJeuo0y2plV1NuSSI3/bzzi3fuP9VogUMFG6n7yXEHkVmJ9PC3C7zn6ITepS5m2CAPuvhhshgJZm0IEU7NA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mdJbdFXo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q4P2QA36; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mdJbdFXo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q4P2QA36" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65IAridO1054973 for ; Thu, 18 Jun 2026 12:36:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tkVdR6Y285QvRNSr/VNZJ0GSaNwFXgkHm0HQbf9tgGU=; b=mdJbdFXo3hnbRguk RZ3ovdXwEe20SpX4nlDzAwxVrsdG7Accag0uXfJBIaGAx1i5fFOBdAyvnUsW7/FQ FlLt44/5TFigBDO/T9BvfTfLRC3nh3NyIW673vjTuhymJgc/LjFi6brIDQAjxMUE 9JTNbQ50MwS+dyF7x+ixJT6olK31U+x10uSnMJTMiJcJThJ4BXnt0PY//FrmZnb6 j0Ogb5IouehBonXtnld870ZWUXhI4stXYqybJF9lEwbrG1gWr3nLG21ZAGNFdbkZ YmjIsdi84yBVNWAfk4pIbptGkZk48XMNRSXwakzkz+6ow3vBSshVAQR8emPkzdGY Yt9bgw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eux2ccg39-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 12:36:34 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5175b7946d5so7370311cf.0 for ; Thu, 18 Jun 2026 05:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781786194; x=1782390994; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tkVdR6Y285QvRNSr/VNZJ0GSaNwFXgkHm0HQbf9tgGU=; b=Q4P2QA36/csfW0Rf/5nGYOvPzU1em4bIB8Zs3yG1hfPWoPBM8Btj0j8QXqqCaCYjd7 ezlcRxmEgtvN56D+n1FG4n3dihbYxmEUelmMqrGsmboJdDUmC7k+czRpW51yQWdl8mb1 f+QYCbdcDTvnCcYjoDMO03AXT/gdZ2sr2omwadNl44LiXGBPcIo3FUd4IKDUNaplWPrS VkUZlBchOWi/iH2yVucD4N+Op5DC92PZacdPC4jPYifXKMPfwKPmbaxv0Lf5GLeXUXfU HRAD2PHf8vybBMf2l3YoJEs+UoRKeK3WgMYlWPW4kQgIxc7i6uACPpWLfPF1k6ja8/zP JfSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781786194; x=1782390994; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tkVdR6Y285QvRNSr/VNZJ0GSaNwFXgkHm0HQbf9tgGU=; b=dJiOpV4MZZnDZ5JR6eOPKjG1pfRLN+/DzD2HquKsvIV6WgoQvmEi8GH+wADfO+Was9 XJZKh+q/4s/2+SsQri3qtb7AsAm0e8rUl+Gkw7XT8XMzxXqHyfTc3ycouqFGHi16E6GX LJ1d7cjNBwgFhcb906E8bVarFij0JGxXuy2NiwQM8DK6JaZkgMgexTcXEl4YyaM2wmfn u9DCdTCQxsxWLuxb0LBDsk0ERIcbYhzXKfQjNbOlKx0PXAszfq68jGy2upJ8DtUIkQRu DiPDwdHpTAHZgElWvo5QizuQmT0HexFB4wuhqRAxembASz4GJKR4GfOPfWG8CQoQWoCW GwCQ== X-Forwarded-Encrypted: i=1; AFNElJ9XWAMoAEC9dTd14doA4Ht1yx2rUqkoGxVRJ7bsyFGqTSF8br//FPMCb36Oihy6GL6d5AyI4T5fFOzooUs=@vger.kernel.org X-Gm-Message-State: AOJu0YxI85RwRhw6qtOUO6YXyNj9PjSS9sbsH2N4lEUXZUye7l13cKP6 M9ylFGNiCLZPn+++d3TOqncYQ7s3SMV+sWzBVc4K65IgmuMaTxZ9893pv1RO2go2dWGKARJa1/l MxSliQQG43yd9FIPftNydsQHqhEyAtPqxYDVa9uVqeypfP5KCD1oUTCtovOpUmaEq5kk= X-Gm-Gg: AfdE7cmYmVb/U6x2JWzj3JhGHMhAvDk1LRc3y0wcP+/fWKjgSoP5/bQKJvV7tb8/6f6 Ti8i/8rBezZSalKSprhp2MMukeT4kiMN0mPiWPQpWtL1gbPL+jNfxWGZVG8tMkEqwcM9+DboAhp IwGNNLYsEcIJHs45OGvM7hgrnnT0C2+3rpjfH7P1GsJ0o9V+gI2otcAGeOs4GUqDTJY4UAar6VO CHP7UJZGvuQusvKehG/XM8FrL+TQWb+yGJIYlv/BZXMEXy4j0+VMiAJ1xu7xCv57o72UJQyO3vK 3+ZYNj697DBdbfZOHU8cbbBmvC3AKzGQho1v/z7NFJZqUJVL/6ODww3TbX0bLJzSUhHdHSONJUt XC5rV4CgW+vfY1S7AypAl4v2Toa1Vs6NjiF4+RjfOx7OAozVcVUsAEhXWMeednDocripnCJYz9U g= X-Received: by 2002:a05:622a:8f0b:b0:517:675f:3ee8 with SMTP id d75a77b69052e-519a8df0360mr119058971cf.12.1781786193888; Thu, 18 Jun 2026 05:36:33 -0700 (PDT) X-Received: by 2002:a05:622a:8f0b:b0:517:675f:3ee8 with SMTP id d75a77b69052e-519a8df0360mr119058481cf.12.1781786193346; Thu, 18 Jun 2026 05:36:33 -0700 (PDT) Received: from [10.111.165.239] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f4ff32a3sm96189716d6.36.2026.06.18.05.36.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 05:36:32 -0700 (PDT) Message-ID: <226a55a6-babd-47ce-b261-35b982d5c7db@oss.qualcomm.com> Date: Thu, 18 Jun 2026 20:36:27 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: i2c: og0va1b: Add OmniVision OG0VA1B camera sensor To: Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260618-og0va1b-v1-0-dda71bb83009@oss.qualcomm.com> <20260618-og0va1b-v1-2-dda71bb83009@oss.qualcomm.com> <1a57863c-831a-411c-a0ae-da3d4f1fd6a0@linaro.org> Content-Language: en-US From: Wenmeng Liu In-Reply-To: <1a57863c-831a-411c-a0ae-da3d4f1fd6a0@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDExNiBTYWx0ZWRfX/fZTDbFBgRmw gCDJcStm1YWzBhhj9ypzm/HU2vnajSVAxDX1PywbECA90S/xo7EvxaGUnsva5rbGD1LdwmGFwVH yrgNfxXHjVEi847tVIUUInvncpSPc/f+oj1OGb70m/X1vc8p+KQKdebq9BF2VF4nEFoZepE0CKu tESPOY6X5qihuaygq8D6oTGksU2pxpB0dKA7IyTOIZCWaaJoaGB/teDSktzL8losA4uCoFgH85T AG7kST9MWgeqKT+E4pClge6ex4jgykmpF9A5NSzLoxrO3S+OHoOXv725GzvNfKmM9pRaz/8TaRa RjvJAAtsQ3PXTXaiybQfvWX45awDjwChPaS7nbGJ4uR9dNQw3sElSoimD5ghxIAPU84K6cnidOv Go3r3yr3OchSGB+uIMkHMxE4kSxDL5+SfCls1rYS9bOvLismqcMWpjLWwNP/LUbxZNiSXxVmkRl CXH1H/Fr6I40NtbVF/A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDExNiBTYWx0ZWRfXwpI1GviSJN6T tVV2ApWAGPC7toV8IgomQ7tB52sYYwfFbagDG04ETyXCK7+KDrN18h0pzREjY8gIn5s6CpJ5r8t 1evHae/MuLX7PA7SBEGnOrmulVLadNM= X-Proofpoint-GUID: F0ZnxpPust66pVLJm-6BZrYMFJlkjnqf X-Proofpoint-ORIG-GUID: F0ZnxpPust66pVLJm-6BZrYMFJlkjnqf X-Authority-Analysis: v=2.4 cv=WN1PmHsR c=1 sm=1 tr=0 ts=6a33e652 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=HvsU3PRRA2NteV8Xgf4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180116 On 6/18/2026 6:50 PM, Vladimir Zapolskiy wrote: > Hello Wenmeng. > > On 6/18/26 13:37, Wenmeng Liu wrote: >> Add V4L2 sub device driver for OmniVision OG0VA1B image sensor. >> OmniVision OG0VA1B is an image sensor, which produces frames in 10-bit >> raw output format (Y10) over a 1-lane MIPI CSI-2 interface and supports >> the 640x480 (VGA) resolution. >> >> Signed-off-by: Wenmeng Liu >> --- >>   MAINTAINERS                 |   1 + >>   drivers/media/i2c/Kconfig   |  10 + >>   drivers/media/i2c/Makefile  |   1 + >>   drivers/media/i2c/og0va1b.c | 867 ++++++++++++++++++++++++++++++++++ >> ++++++++++ >>   4 files changed, 879 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index >> 5aa846c8479b20651291d5bd2e316308310f826c..85a06eb9eacc410a565b80d56979eaa565515d0e 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -19891,6 +19891,7 @@ M:    Wenmeng Liu >>   L:    linux-media@vger.kernel.org >>   S:    Maintained >>   F:    Documentation/devicetree/bindings/media/i2c/ovti,og0va1b.yaml >> +F:    drivers/media/i2c/og0va1b.c >>   OMNIVISION OG0VE1B SENSOR DRIVER >>   M:    Vladimir Zapolskiy >> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig >> index >> 5d173e0ecf424f2f204f8d426be818e44357f8e4..56680772f5f47b4629c4e17f5a5feba08b1d94fc 100644 >> --- a/drivers/media/i2c/Kconfig >> +++ b/drivers/media/i2c/Kconfig >> @@ -363,6 +363,16 @@ config VIDEO_OG01A1B >>         To compile this driver as a module, choose M here: the >>         module will be called og01a1b. >> +config VIDEO_OG0VA1B >> +    tristate "OmniVision OG0VA1B sensor support" >> +    select V4L2_CCI_I2C >> +    help >> +      This is a Video4Linux2 sensor driver for the OmniVision >> +      OG0VA1B camera. >> + >> +      To compile this driver as a module, choose M here: the >> +      module will be called og0va1b. >> + >>   config VIDEO_OG0VE1B >>       tristate "OmniVision OG0VE1B sensor support" >>       select V4L2_CCI_I2C >> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile >> index >> e45359efe0e41e13e3c0869e5ead7d6cf4aca3a7..c60851c7fe07e3bdc511c5f482525ba7a044f48e 100644 >> --- a/drivers/media/i2c/Makefile >> +++ b/drivers/media/i2c/Makefile >> @@ -83,6 +83,7 @@ obj-$(CONFIG_VIDEO_MT9V011) += mt9v011.o >>   obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o >>   obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o >>   obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o >> +obj-$(CONFIG_VIDEO_OG0VA1B) += og0va1b.o >>   obj-$(CONFIG_VIDEO_OG0VE1B) += og0ve1b.o >>   obj-$(CONFIG_VIDEO_OS05B10) += os05b10.o >>   obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o >> diff --git a/drivers/media/i2c/og0va1b.c b/drivers/media/i2c/og0va1b.c >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..f0505b7ba7f329ad57ffafa8f90a24204f002d3c >> --- /dev/null >> +++ b/drivers/media/i2c/og0va1b.c >> @@ -0,0 +1,867 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * OmniVision OG0VA1B Camera Sensor Driver >> + * >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define OG0VA1B_REG_CHIP_ID        CCI_REG16(0x300a) >> +#define OG0VA1B_CHIP_ID            0xC756 > > This is the same chip id as of the OG0VE1B sensor device. > > What's the difference between these two sensors, and do you find it > possible > to add support of OG0VA1B sensor/modes into OG0VE1B sensor driver? Or is > it just the same device? > > Hardware specifics described in dt changes also does not show a difference > in comparison to ovti,og0ve1b.yaml. > Hi Vladimir, Both OG0VE1B and OG0VA1B belong to the same OmniVision VGA monochrome sensor family. They share the same resolution, power rails, reset GPIO behavior and power management framework. But they are different: OG0VE1B: 8-bit RAW, lower FPS OG0VA1B: 10-bit RAW, higher FPS and some registers are not same. The DT bindings can be reused, but would it be more appropriate for the driver to remain independent? Thanks, Wenmeng