From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4CFC64E7C for ; Wed, 2 Dec 2020 11:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3AF42223C for ; Wed, 2 Dec 2020 11:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbgLBL2z (ORCPT ); Wed, 2 Dec 2020 06:28:55 -0500 Received: from comms.puri.sm ([159.203.221.185]:54722 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbgLBL2z (ORCPT ); Wed, 2 Dec 2020 06:28:55 -0500 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 96F63E1180; Wed, 2 Dec 2020 03:27:44 -0800 (PST) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8omf0pHFn30F; Wed, 2 Dec 2020 03:27:43 -0800 (PST) Subject: Re: [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq To: Krzysztof Kozlowski Cc: Georgi Djakov , robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com, catalin.marinas@arm.com, will@kernel.org, cdleonard@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, kernel@puri.sm, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org References: <20201201123932.12312-1-martin.kepplinger@puri.sm> <20201201123932.12312-8-martin.kepplinger@puri.sm> <20201202080321.GB6087@kozik-lap> From: Martin Kepplinger Message-ID: <226e76a8-011e-ece5-d8fa-b52dbc81787b@puri.sm> Date: Wed, 2 Dec 2020 12:27:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.12.20 09:05, Krzysztof Kozlowski wrote: > On Wed, 2 Dec 2020 at 10:03, Krzysztof Kozlowski wrote: >> >> On Tue, Dec 01, 2020 at 02:15:04PM +0100, Martin Kepplinger wrote: >>> On 01.12.20 14:10, Georgi Djakov wrote: >>>> On 1.12.20 14:39, Martin Kepplinger wrote: >>>>> Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely >>>>> available for testing. >>>> >>>> I hope that it's not just for testing, but using it. >>> >>> sure, I just think that most people will use their own config for production >>> but that's a different story. I can rephrase. >>> >>>> >>>>> Signed-off-by: Martin Kepplinger >>>>> --- >>>>> arch/arm64/configs/defconfig | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>> index 1fed16950a7c..830c26a95b3d 100644 >>>>> --- a/arch/arm64/configs/defconfig >>>>> +++ b/arch/arm64/configs/defconfig >>>>> @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y >>>>> CONFIG_MUX_MMIO=y >>>>> CONFIG_SLIM_QCOM_CTRL=m >>>>> CONFIG_SLIM_QCOM_NGD_CTRL=m >>>>> -CONFIG_INTERCONNECT=y >>>> >>>> Why are you removing this line? >>> >>> savedefconfig removes it. INTERCONNECT_IMX below depends on it. >> >> It's save to remove it as other Interconnect options are directly >> dependant. > > Ugh, my bad, it is not allowed to remove it. My review was too fast. > INTERCONNECT_IMX depends on it, so the INTERCONNECT must stay, > > It is selected by TEGRA_MC which is independent here, so you should keep it. > thanks for reviewing! Just to be clear: We're talking about defconfig, so if I keep INTERCONNECT that means that I do `make savedefconfig` which removes it (it's of course still enabled, just redundant in defconfig output), and then *manually* add INTERCONNECT. That would indicate that there's a Kconfig bug. thanks, martin