From: Petr Pavlu <petr.pavlu@suse.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Aaron Tomlin <atomlin@atomlin.com>,
linux-modules@vger.kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] module/kallsyms: Rename is_mapping_symbol() to is_local_mapping_symbol()
Date: Thu, 20 Aug 2026 11:53:37 +0200 [thread overview]
Message-ID: <226fd868-b51d-4ec4-b13f-520ccd0e8e36@suse.com> (raw)
In-Reply-To: <d22a5f25-b4b3-faa4-46d5-132f3fa725f3@loongson.cn>
On 8/18/26 3:04 PM, Tiezhu Yang wrote:
> On 2026/8/18 下午7:56, Petr Pavlu wrote:
>> Another comment-only reference to is_mapping_symbol() that should be
>> updated is in tools/perf/util/symbol.h.
>
> There may be conflicts between modules-next and perf-tools-next:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git/log/tools/perf/util/symbol.h?h=modules-next
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/tools/perf/util/symbol.h?h=perf-tools-next
>
> So one way is to not modify tools/perf/util/symbol.h if based
> on modules-next at this time, the other way is to rebase the
> code and then send the series after the merge window.
>
> Please let me know what is the proper way.
I don't immediately see that updating the comment in
tools/perf/util/symbol.h would cause a conflict with either modules-next
or perf-tools-next.
I think you can even base the series on mainline. It applies cleanly
to v7.2. If there happens to be a conflict, it should be minor and I can
deal with it.
Importantly, please Cc the maintainers of the updated non-module files
(scripts/faddr2line, scripts/mod/modpost.h, tools/perf/util/symbol.h) in
the next version of this patch so they are aware of the change.
--
Thanks,
Petr
next prev parent reply other threads:[~2026-08-20 9:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 3:28 [PATCH v3 0/3] Filter out local and mapping symbols during module load Tiezhu Yang
2026-08-12 3:28 ` [PATCH v3 1/3] module/kallsyms: Rename is_mapping_symbol() to is_local_mapping_symbol() Tiezhu Yang
2026-08-18 11:56 ` Petr Pavlu
2026-08-18 13:04 ` Tiezhu Yang
2026-08-20 9:53 ` Petr Pavlu [this message]
2026-08-12 3:28 ` [PATCH v3 2/3] module/kallsyms: Refactor current symbol filtering into is_kept_symbol() Tiezhu Yang
2026-08-18 11:58 ` Petr Pavlu
2026-08-18 13:05 ` Tiezhu Yang
2026-08-12 3:28 ` [PATCH v3 3/3] module/kallsyms: Filter out local and mapping symbols during module load Tiezhu Yang
2026-08-18 11:59 ` Petr Pavlu
2026-08-18 13:06 ` Tiezhu Yang
2026-08-12 15:17 ` [PATCH v3 0/3] " Huacai Chen
2026-08-17 14:11 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226fd868-b51d-4ec4-b13f-520ccd0e8e36@suse.com \
--to=petr.pavlu@suse.com \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=samitolvanen@google.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®