From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esg.nwe.de (esg.nwe.de [195.226.126.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2931342ABE for ; Fri, 12 Apr 2024 06:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.226.126.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712904447; cv=none; b=C2Fnr4+U5TIdWb3UON26GaFoTzANgsVQBRfJr+Q5hXfWr/g6UCSRCnEaBaLSbnn66ctYkpMZyfdb5/6vrFd1H/DaWjYAKAyrQN3mt0xInnsJubTnYuJVyFlFA+IZ/OM09fY5pijGkf4pjXKS8q66v6BTrD3LNntn/qrQMrqNyZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712904447; c=relaxed/simple; bh=rUn7NaZAS5hnRq6kHRzju/FnH7ibYcmkgTvUbuxKoxg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=iRjZ/cm5eR4jm2GgT6vy8to3IY8h3+BvfqLgyjoN1wLNdEZg6LBgrTPFndQEA/eEfRuVVEPzGaxQTbbDnlaRWv1plYa4asDxJ59fyyEWX1xXmCnIsNAWTzLN9HioNWToBS9z2TMyNIL6uMFizrg6R76uFRQg+kYmCkxn/I7DEU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=scram.de; spf=pass smtp.mailfrom=scram.de; dkim=pass (1024-bit key) header.d=scram.de header.i=@scram.de header.b=QU0RfYY8; arc=none smtp.client-ip=195.226.126.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=scram.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=scram.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=scram.de header.i=@scram.de header.b="QU0RfYY8" X-ASG-Debug-ID: 1712903570-1ed71d5dc82363b80001-xx1T2L Received: from mail.scram.de ([213.206.175.31]) by esg.nwe.de with ESMTP id 2CinZMVeoB7m5L6B (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 12 Apr 2024 08:32:50 +0200 (CEST) X-Barracuda-Envelope-From: jochen@scram.de X-Barracuda-Effective-Source-IP: UNKNOWN[213.206.175.31] X-Barracuda-Apparent-Source-IP: 213.206.175.31 Received: (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender) by mail.scram.de (Postfix) with ESMTPSA id F29EF8A7031; Fri, 12 Apr 2024 08:32:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.scram.de F29EF8A7031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scram.de; s=mail2021; t=1712903570; bh=Gh1QR2+zPfWSt6AeuaYH86pSHzi1XIf0LhYJrlsTzsg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=QU0RfYY8DbePZ5cSqGjXgEv7Vqq8xXXIJdVQk1JyOqck38FEgC4x4H3/iUqgARSmp w/FjXl7ccBDgbfreaX/myLtF/cvSFBvQddT0I9Vr126eXMNC1gHQ5Fe2HBPVZf382k oaWYoJzQMfqct/IRNrqiFhe7B7263vktH3B2taw8= Message-ID: <2271dcf2-83c3-4570-87f5-c483faa2f9cd@scram.de> Date: Fri, 12 Apr 2024 08:32:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/64] i2c: cpm: reword according to newest specification To: Andi Shyti , Wolfram Sang , linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org X-ASG-Orig-Subj: Re: [PATCH 14/64] i2c: cpm: reword according to newest specification References: <20240322132619.6389-1-wsa+renesas@sang-engineering.com> <20240322132619.6389-15-wsa+renesas@sang-engineering.com> <26y3smrxv3q56peuqatospr3q6annxvdmleyhykyrjrovne6mu@yg44mmr7aaqp> From: Jochen Friedrich In-Reply-To: <26y3smrxv3q56peuqatospr3q6annxvdmleyhykyrjrovne6mu@yg44mmr7aaqp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: UNKNOWN[213.206.175.31] X-Barracuda-Start-Time: 1712903570 X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256 X-Barracuda-URL: https://195.226.126.84:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at nwe.de X-Barracuda-Scan-Msg-Size: 423 X-Barracuda-BRTS-Status: 0 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=5.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.123398 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- >>>> out_8(&cpm->i2c_reg->i2mod, 0x00); >>>> - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ >>>> + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ >>> I2COM_MASTER might be coming from the datasheet. >> Maybe we can just drop the comment? The value we write is pretty >> self-explaining. > indeed. > > Andi I also agree. You might add my Acked-By: here. Jochen