From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v2] cpufreq: stats: Walk online CPUs with CPU offline/online locked
Date: Fri, 20 May 2016 03:41:32 +0200 [thread overview]
Message-ID: <2278154.xyiFOocWfq@vostro.rjw.lan> (raw)
In-Reply-To: <19792191.esL3UuyORb@vostro.rjw.lan>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Loops over online CPUs in cpufreq_stats_init() and cpufreq_stats_exit()
should be carried out with CPU offline/online locked or races are
possible otherwise, so make that happen.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
v1 -> v2: On a second thought, add the policy notifier in cpufreq_stats_init()
with CPU offline/online locked too.
---
drivers/cpufreq/cpufreq_stats.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
Index: linux-pm/drivers/cpufreq/cpufreq_stats.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/cpufreq_stats.c
+++ linux-pm/drivers/cpufreq/cpufreq_stats.c
@@ -317,10 +317,13 @@ static int __init cpufreq_stats_init(voi
unsigned int cpu;
spin_lock_init(&cpufreq_stats_lock);
+
+ get_online_cpus();
+
ret = cpufreq_register_notifier(¬ifier_policy_block,
CPUFREQ_POLICY_NOTIFIER);
if (ret)
- return ret;
+ goto out;
for_each_online_cpu(cpu)
cpufreq_stats_create_table(cpu);
@@ -332,21 +335,28 @@ static int __init cpufreq_stats_init(voi
CPUFREQ_POLICY_NOTIFIER);
for_each_online_cpu(cpu)
cpufreq_stats_free_table(cpu);
- return ret;
}
- return 0;
+ out:
+ put_online_cpus();
+
+ return ret;
}
static void __exit cpufreq_stats_exit(void)
{
unsigned int cpu;
+ get_online_cpus();
+
cpufreq_unregister_notifier(¬ifier_policy_block,
CPUFREQ_POLICY_NOTIFIER);
cpufreq_unregister_notifier(¬ifier_trans_block,
CPUFREQ_TRANSITION_NOTIFIER);
+
for_each_online_cpu(cpu)
cpufreq_stats_free_table(cpu);
+
+ put_online_cpus();
}
MODULE_AUTHOR("Zou Nan hai <nanhai.zou@intel.com>");
next prev parent reply other threads:[~2016-05-20 1:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 1:34 [PATCH] " Rafael J. Wysocki
2016-05-20 1:41 ` Rafael J. Wysocki [this message]
2016-05-20 2:22 ` [PATCH v2] " Viresh Kumar
2016-05-20 12:13 ` Rafael J. Wysocki
2016-05-20 21:33 ` Rafael J. Wysocki
2016-05-23 3:57 ` Viresh Kumar
2016-05-23 13:40 ` Rafael J. Wysocki
2016-05-23 15:19 ` Viresh Kumar
2016-05-23 20:47 ` Rafael J. Wysocki
2016-05-24 4:56 ` Viresh Kumar
2016-05-24 12:13 ` Rafael J. Wysocki
2016-05-24 12:17 ` Viresh Kumar
2016-05-25 0:00 ` Rafael J. Wysocki
2016-05-25 0:48 ` Rafael J. Wysocki
2016-05-25 2:07 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2278154.xyiFOocWfq@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®