From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E74C7619A for ; Wed, 12 Apr 2023 12:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231607AbjDLMKA (ORCPT ); Wed, 12 Apr 2023 08:10:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231538AbjDLMJ4 (ORCPT ); Wed, 12 Apr 2023 08:09:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07A0E1B0 for ; Wed, 12 Apr 2023 05:09:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A61A62950 for ; Wed, 12 Apr 2023 12:09:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E744EC4339B; Wed, 12 Apr 2023 12:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681301386; bh=Q+87XKVYuHwf+nmYe7F44XKhOf48mLS9pm4sbsH0fJw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ucgwjt/JPi5iZBPiy03c3YjdzLa/tyjWToGByShxa6PtzxhvkezWW1ZuIqn6RWHpw ulsHMsvuSEGNIYzRORzPn719W4w3bCU5mjd3wnrk8aKgdzsqwe+NPPoGRB/nK3pvGO YQwuBSKS1PjkopVhcwBMwPPwoyJ0k4xev8HS1P6vdMDcXn5aI1XcRTQ2DT2PY0mEVk 4f48BGrJdpgJUt4zI+JdF80ZlxlyMYO+qMS8/+h+ZBgZup/aRP8Mv6tlzaKyr6DU9v RoabMnbBLovhI+2sYZdIqiVpqETP/2ZC+OzJ8xQADo425ZxwNdI80KNNh63q59Ej7i ihvHDpBg3+xgw== Date: Wed, 12 Apr 2023 13:09:41 +0100 From: Mark Brown To: Baili Deng Cc: Guenter Roeck , David Rau , support.opensource@diasemi.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: da7219: Improve the relability of AAD IRQ process Message-ID: <227d1f11-dea0-400a-96c9-dee568730a13@sirena.org.uk> References: <20230410092634.4870-1-David.Rau.opensource@dm.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HGqq5x0t3aI77m3z" Content-Disposition: inline In-Reply-To: X-Cookie: Happy feast of the pig! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HGqq5x0t3aI77m3z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 12, 2023 at 10:32:47AM +0800, Baili Deng wrote: > The change in the patch done to address the issue Geunter mentioned is that > da7219_aad_handle_gnd_switch_time() is now called before interrupts are > enabled. To address the msleep() issue, the delay is now added as a delayed > work of its own workqueue. The point with the question was that this sort of stuff should be in the commit messages. I can't really tell what the change is supposed to do as things stand. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. --HGqq5x0t3aI77m3z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQ2n4QACgkQJNaLcl1U h9Anygf/ZHIBfSJdWGpYgQ5BSRZ4BRIeIzoPwlN7HkXB7lURVXdyGnp9YPjzvLa1 9wRVQOX7rhvketKQX64797qKzSplQoOKLudaRkjdWQHllB6HZpciEJ56kdHMKZoP 3u4HU4fMSIgNw5DV2lRJ47q8fjxm9pB3G51eSvFgpgPFWXs1OKzU058x5n8QYRzG LDE6UlciSv2m+jW8Z12EPVNxRKmX6RS8C+Jy8GYFGhTU79mdIpeoAAHpYnF2eFfS s4pEBCm0LCE1ySS/rf1Vf6s6Ayn+Gu1vavK/GaXa18MXJ08aozU8VxeIEr/vxgPN BkMGapPp/y8XiseNNXv1m4bMF26HFA== =n3/l -----END PGP SIGNATURE----- --HGqq5x0t3aI77m3z--