mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	"Russell King" <linux@armlinux.org.uk>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Helge Deller" <deller@gmx.de>,
	"Geoff Levand" <geoff@infradead.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Len Brown" <lenb@kernel.org>,
	"William Breathitt Gray" <vilhelm.gray@gmail.com>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Alison Schofield" <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Ben Widawsky" <ben.widawsky@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Stefan Richter" <stefanr@s5r6.in-berlin.de>,
	"Sudeep Holla" <sudeep.holla@arm.com>,
	"Cristian Marussi" <cristian.marussi@arm.com>,
	"Wu Hao" <hao.wu@intel.com>, "Tom Rix" <trix@redhat.com>,
	"Moritz Fischer" <mdf@kernel.org>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Stephen Hemminger" <sthemmin@microsoft.com>,
	"Wei Liu" <wei.liu@kernel.org>,
	"Dexuan Cui" <decui@microsoft.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Jens Taprogge" <jens.taprogge@taprogge.org>,
	"Johannes Thumshirn" <morbidrsa@gmail.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Maxim Levitsky" <maximlevitsky@gmail.com>,
	"Alex Dubov" <oakad@ya>
Subject: Re: [PATCH] bus: Make remove callback return void
Date: Tue, 06 Jul 2021 14:50:40 +0200	[thread overview]
Message-ID: <22817b58fe78a803af3440b7571922289fdb87f8.camel@igalia.com> (raw)
In-Reply-To: <YORBc384OjIBC/Yj@kuha.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

On Tue, 2021-07-06 at 14:41 +0300, Heikki Krogerus wrote:
> On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote:
> > The driver core ignores the return value of this callback because
> > there
> > is only little it can do when a device disappears.
> > 
> > This is the final bit of a long lasting cleanup quest where several
> > buses were converted to also return void from their remove callback.
> > Additionally some resource leaks were fixed that were caused by
> > drivers
> > returning an error code in the expectation that the driver won't go
> > away.
> > 
> > With struct bus_type::remove returning void it's prevented that newly
> > implemented buses return an ignored error code and so don't
> > anticipate
> > wrong expectations for driver authors.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 

For ipack changes:

Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Thanks,

Sam

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-07-06 12:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  9:50 Uwe Kleine-König
2021-07-06  9:56 ` Russell King (Oracle)
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:24 ` Chen-Yu Tsai
2021-07-06 10:25 ` Pali Rohár
2021-07-06 10:26 ` Mauro Carvalho Chehab
2021-07-06 10:28 ` Hans de Goede
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:47   ` Johannes Thumshirn
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:46 ` Juergen Gross
2021-07-06 10:49 ` Johan Hovold
2021-07-06 10:56 ` Srinivas Kandagatla
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 11:17   ` Cornelia Huck
2021-07-06 12:14     ` Uwe Kleine-König
2021-07-06 11:16 ` Kirti Wankhede
2021-07-06 11:42 ` Maximilian Luz
     [not found] ` <YORBc384OjIBC/Yj@kuha.fi.intel.com>
2021-07-06 12:50   ` Samuel Iglesias Gonsálvez [this message]
2021-07-06 13:52 ` Tom Rix
2021-07-08  2:19   ` Xu Yilun
2021-07-08  5:32     ` Uwe Kleine-König
2021-07-06 14:51 ` Geoff Levand
2021-07-06 15:06 ` Yehezkel Bernat
2021-07-06 15:11 ` Mathieu Poirier
2021-07-06 15:11 ` Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22817b58fe78a803af3440b7571922289fdb87f8.camel@igalia.com \
    --to=siglesias@igalia.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alison.schofield@intel.com \
    --cc=ben.widawsky@intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=cristian.marussi@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=decui@microsoft.com \
    --cc=deller@gmx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=geoff@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=hao.wu@intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jens.taprogge@taprogge.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jikos@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kys@microsoft.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maximlevitsky@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=mdf@kernel.org \
    --cc=morbidrsa@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=mripard@kernel.org \
    --cc=oakad@ya \
    --cc=paulus@samba.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=sthemmin@microsoft.com \
    --cc=sudeep.holla@arm.com \
    --cc=trix@redhat.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vilhelm.gray@gmail.com \
    --cc=vishal.l.verma@intel.com \
    --cc=vkoul@kernel.org \
    --cc=wei.liu@kernel.org \
    --cc=wens@csie.org \
    --cc=wsa@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®