mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Cho, Yu-Chen" <acho@novell.com>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, segooon@gmail.com,
	huajun.li.lee@gmail.com, kkatuev@gmail.com, jj@chaosbits.net,
	imirkin@alum.mit.edu, devel@driverdev.osuosl.org,
	jlee@novell.com, acho@novell.com
Subject: [PATCH 7/7] staging/keucr : fix transport other code style
Date: Wed, 18 May 2011 18:40:15 +0800	[thread overview]
Message-ID: <2282da69f10c9ce719ce08d17cbd10c047e1b028.1305714525.git.acho@novell.com> (raw)
In-Reply-To: <cover.1305714525.git.acho@novell.com>
In-Reply-To: <cover.1305714525.git.acho@novell.com>

fix keucr transport.c other coding style but not from checkpatch.pl.
replace ternary conditional "?:" with if/else

Signed-off-by: Cho, Yu-Chen <acho@novell.com>
---
 drivers/staging/keucr/transport.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/keucr/transport.c b/drivers/staging/keucr/transport.c
index d48f592..0274cb0 100644
--- a/drivers/staging/keucr/transport.c
+++ b/drivers/staging/keucr/transport.c
@@ -629,8 +629,12 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)
 
 	/*  R/W data */
 	if (transfer_length) {
-		unsigned int pipe = srb->sc_data_direction ==
-		DMA_FROM_DEVICE ? us->recv_bulk_pipe : us->send_bulk_pipe;
+		unsigned int pipe;
+		if (srb->sc_data_direction == DMA_FROM_DEVICE)
+			pipe = us->recv_bulk_pipe;
+		else
+			pipe = us->send_bulk_pipe;
+
 		result = usb_stor_bulk_srb(us, pipe, srb);
 		/* pr_info("Bulk data transfer result 0x%x\n", result); */
 		if (result == USB_STOR_XFER_ERROR)
-- 
1.7.1


      parent reply	other threads:[~2011-05-18 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 10:40 [PATCH 0/7] staging/keucr: fix keucr coding style Cho, Yu-Chen
2011-05-18 10:40 ` [PATCH 1/7] staging/keucr: fix keucr ms " Cho, Yu-Chen
2011-05-18 10:40 ` [PATCH 2/7] staging/keucr: fix keucr msscsi " Cho, Yu-Chen
2011-05-18 10:40 ` [PATCH 3/7] staging/keucr: fix keucr scsiglue " Cho, Yu-Chen
2011-05-18 10:40 ` [PATCH 4/7] staging/keucr: fix keucr smilecc.c " Cho, Yu-Chen
2011-05-18 10:40 ` [PATCH 5/7] staging/keucr: fix keucr smil.h " Cho, Yu-Chen
2011-05-18 10:40 ` [PATCH 6/7] staging/keucr: fix keucr transport " Cho, Yu-Chen
2011-05-18 10:40 ` Cho, Yu-Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2282da69f10c9ce719ce08d17cbd10c047e1b028.1305714525.git.acho@novell.com \
    --to=acho@novell.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=huajun.li.lee@gmail.com \
    --cc=imirkin@alum.mit.edu \
    --cc=jj@chaosbits.net \
    --cc=jlee@novell.com \
    --cc=kkatuev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=segooon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®