From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbbCNVDW (ORCPT ); Sat, 14 Mar 2015 17:03:22 -0400 Received: from forward19o.cmail.yandex.net ([37.9.109.217]:55336 "EHLO forward19o.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbbCNVDT (ORCPT ); Sat, 14 Mar 2015 17:03:19 -0400 X-Greylist: delayed 478 seconds by postgrey-1.27 at vger.kernel.org; Sat, 14 Mar 2015 17:03:18 EDT From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: David Fries Cc: Thorsten Bschorr , Jonathan ALIBERT , "linux-kernel@vger.kernel.org" In-Reply-To: <20150312005408.GD23778@spacedout.fries.net> References: <20150228201737.GU6151@spacedout.fries.net> <369891425174502@web4m.yandex.ru> <20150301021744.GW6151@spacedout.fries.net> <20150302001713.GA6151@spacedout.fries.net> <4333121425483401@web21m.yandex.ru> <20150308211449.GG11991@spacedout.fries.net> <20150309230924.GJ11991@spacedout.fries.net> <2663771425995520@web30h.yandex.ru> <20150312005408.GD23778@spacedout.fries.net> Subject: Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm MIME-Version: 1.0 Message-Id: <2283421426366516@web2o.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sat, 14 Mar 2015 23:55:16 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David 12.03.2015, 03:54, "David Fries" : > Would that be removing all four refcnt, w1_slave, w1_master, > w1_family, w1_cb_block, or just some of them? šIt sounds good to me, > if that had bugs there would be much more than just the w1 system > relying on it. šI don't know enough about that system or have the time > to code up that change. > > I can take another look at and post the reference counting w1_therm > fix instead of the mutex version as a near term work around until that > is available if you want. Please cook up a quick fix for this problem - this bug really hurts people. And then we will discuss how 'ideal' life cycle should look