From: Arnd Bergmann <arnd@arndb.de>
To: suravee.suthikulpanit@amd.com
Cc: mark.rutland@arm.com, will.deacon@arm.com, marc.zyngier@arm.com,
catalin.marinas@arm.com, robherring2@gmail.com,
liviu.dudau@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Joel Schopp <Joel.Schopp@amd.com>
Subject: Re: [PATCH V4] arm64: amd-seattle: Adding device tree for AMD Seattle platform
Date: Tue, 25 Nov 2014 12:57:30 +0100 [thread overview]
Message-ID: <2285363.CoMWhviz1f@wuerfel> (raw)
In-Reply-To: <1416865877-8347-1-git-send-email-suravee.suthikulpanit@amd.com>
On Monday 24 November 2014 15:51:17 suravee.suthikulpanit@amd.com wrote:
>
> + gic: interrupt-controller@e1101000 {
> + compatible = "arm,gic-400", "arm,cortex-a15-gic";
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + reg = <0x0 0xe1110000 0 0x1000>,
> + <0x0 0xe112f000 0 0x2000>,
> + <0x0 0xe1140000 0 0x10000>,
> + <0x0 0xe1160000 0 0x10000>;
> + interrupts = <1 9 0xf04>;
> + ranges;
> + v2m0: v2m@e1180000 {
> + compatible = "arm,gic-v2m-frame";
> + msi-controller;
> + arm,msi-base-spi = <64>;
> + arm,msi-num-spis = <256>;
> + reg = <0x0 0xe1180000 0 0x1000>;
> + };
> + };
Having an empty ranges property in the gic seems strange, especially
since the registers of the v2m seem to directly follow the gic's own
registers. Could you limit the ranges to only the registers that
are in the gic or its child devices itself?
Arnd
next prev parent reply other threads:[~2014-11-25 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 21:51 suravee.suthikulpanit
2014-11-24 23:09 ` Olof Johansson
2014-11-25 8:38 ` Suthikulpanit, Suravee
2014-11-25 10:23 ` Marc Zyngier
2014-11-25 11:46 ` Suthikulpanit, Suravee
2014-11-27 14:28 ` Liviu Dudau
2014-11-27 14:45 ` Marc Zyngier
2014-11-25 11:57 ` Arnd Bergmann [this message]
2014-11-25 20:39 ` Suthikulpanit, Suravee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2285363.CoMWhviz1f@wuerfel \
--to=arnd@arndb.de \
--cc=Joel.Schopp@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=arm@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=robherring2@gmail.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®