From: neil.armstrong@linaro.org
To: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abel.vesa@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: rename vph-pwr regulator nodes
Date: Tue, 15 Oct 2024 14:27:01 +0200 [thread overview]
Message-ID: <2287a783-d00b-4175-8ac0-a6e86dc9245d@linaro.org> (raw)
In-Reply-To: <20241015122601.16127-1-johan+linaro@kernel.org>
On 15/10/2024 14:26, Johan Hovold wrote:
> Rename the x1e80100 vph-pwr regulator nodes to use "regulator" as a
> prefix for consistency with the other fixed regulators.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../dts/qcom/x1e80100-asus-vivobook-s15.dts | 22 +++++++++----------
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 22 +++++++++----------
> .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 22 +++++++++----------
> .../dts/qcom/x1e80100-microsoft-romulus.dtsi | 22 +++++++++----------
> 4 files changed, 44 insertions(+), 44 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> index 20616bd4aa6c..b1f190a9686f 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> @@ -94,17 +94,6 @@ linux,cma {
> };
> };
>
> - vph_pwr: vph-pwr-regulator {
> - compatible = "regulator-fixed";
> -
> - regulator-name = "vph_pwr";
> - regulator-min-microvolt = <3700000>;
> - regulator-max-microvolt = <3700000>;
> -
> - regulator-always-on;
> - regulator-boot-on;
> - };
> -
> vreg_edp_3p3: regulator-edp-3p3 {
> compatible = "regulator-fixed";
>
> @@ -135,6 +124,17 @@ vreg_nvme: regulator-nvme {
> pinctrl-0 = <&nvme_reg_en>;
> pinctrl-names = "default";
> };
> +
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> };
>
> &apps_rsc {
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 4ab7078f76e0..4ab9e0ca4591 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -261,17 +261,6 @@ platform {
> };
> };
>
> - vph_pwr: vph-pwr-regulator {
> - compatible = "regulator-fixed";
> -
> - regulator-name = "vph_pwr";
> - regulator-min-microvolt = <3700000>;
> - regulator-max-microvolt = <3700000>;
> -
> - regulator-always-on;
> - regulator-boot-on;
> - };
> -
> vreg_edp_3p3: regulator-edp-3p3 {
> compatible = "regulator-fixed";
>
> @@ -319,6 +308,17 @@ vreg_nvme: regulator-nvme {
> pinctrl-0 = <&nvme_reg_en>;
> };
>
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> vreg_wwan: regulator-wwan {
> compatible = "regulator-fixed";
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index 3c13331a9ef4..10ba934652c3 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -166,17 +166,6 @@ platform {
> };
> };
>
> - vph_pwr: vph-pwr-regulator {
> - compatible = "regulator-fixed";
> -
> - regulator-name = "vph_pwr";
> - regulator-min-microvolt = <3700000>;
> - regulator-max-microvolt = <3700000>;
> -
> - regulator-always-on;
> - regulator-boot-on;
> - };
> -
> vreg_edp_3p3: regulator-edp-3p3 {
> compatible = "regulator-fixed";
>
> @@ -206,6 +195,17 @@ vreg_nvme: regulator-nvme {
> pinctrl-0 = <&nvme_reg_en>;
> pinctrl-names = "default";
> };
> +
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> };
>
> &apps_rsc {
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
> index 42e02ad6a9c3..c47a63b5c85b 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
> @@ -125,17 +125,6 @@ linux,cma {
> };
> };
>
> - vph_pwr: vph-pwr-regulator {
> - compatible = "regulator-fixed";
> -
> - regulator-name = "vph_pwr";
> - regulator-min-microvolt = <3700000>;
> - regulator-max-microvolt = <3700000>;
> -
> - regulator-always-on;
> - regulator-boot-on;
> - };
> -
> vreg_edp_3p3: regulator-edp-3p3 {
> compatible = "regulator-fixed";
>
> @@ -165,6 +154,17 @@ vreg_nvme: regulator-nvme {
> pinctrl-0 = <&nvme_reg_en>;
> pinctrl-names = "default";
> };
> +
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> };
>
> &apps_rsc {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-10-15 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 12:26 Johan Hovold
2024-10-15 12:27 ` neil.armstrong [this message]
2024-10-15 13:08 ` Dmitry Baryshkov
2024-10-16 15:32 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2287a783-d00b-4175-8ac0-a6e86dc9245d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®