From: Lucas Stach <dev@lynxeye.de>
To: Marcel Ziswiler <marcel@ziswiler.com>, linux-tegra@vger.kernel.org
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jonathan Hunter <jonathanh@nvidia.com>,
David Airlie <airlied@linux.ie>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/tegra: hdmi: probe deferral error reporting
Date: Mon, 23 Jul 2018 22:49:15 +0200 [thread overview]
Message-ID: <228cdf6fe37298223d77b52fd4cdb821b0da7d11.camel@lynxeye.de> (raw)
In-Reply-To: <20180720075515.26852-1-marcel@ziswiler.com>
Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
This is still noisy, so while you are changing this I would prefer if
this wouldn't print the error message if it's a simple probe deferral.
Suppressing the log message in that case gets us much cleaner kernel
logs, where real errors stand out.
Regards,
Lucas
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> drivers/gpu/drm/tegra/hdmi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
> index 0082468f703c..94c182dbb6d0 100644
> --- a/drivers/gpu/drm/tegra/hdmi.c
> +++ b/drivers/gpu/drm/tegra/hdmi.c
> @@ -1693,14 +1693,16 @@ static int tegra_hdmi_probe(struct platform_device *pdev)
>
> hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
> if (IS_ERR(hdmi->hdmi)) {
> - dev_err(&pdev->dev, "failed to get HDMI regulator\n");
> - return PTR_ERR(hdmi->hdmi);
> + err = PTR_ERR(hdmi->hdmi);
> + dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", err);
> + return err;
> }
>
> hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
> if (IS_ERR(hdmi->pll)) {
> - dev_err(&pdev->dev, "failed to get PLL regulator\n");
> - return PTR_ERR(hdmi->pll);
> + err = PTR_ERR(hdmi->pll);
> + dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", err);
> + return err;
> }
>
> hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");
next prev parent reply other threads:[~2018-07-23 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 7:55 Marcel Ziswiler
2018-07-23 20:49 ` Lucas Stach [this message]
2018-07-24 5:55 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=228cdf6fe37298223d77b52fd4cdb821b0da7d11.camel@lynxeye.de \
--to=dev@lynxeye.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®