From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Jacopo Mondi <jacopo@jmondi.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Luca Ceresoli <luca@lucaceresoli.net>,
Mark Rutland <mark.rutland@arm.com>,
Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Peter Rosin <peda@axentia.se>, Rob Herring <robh+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Wolfram Sang <wsa@the-dreams.de>,
satish.nagireddy@getcruise.com
Subject: Re: [PATCH v4 0/8] i2c-atr and FPDLink
Date: Mon, 7 Nov 2022 14:12:57 +0200 [thread overview]
Message-ID: <228da3c5-44b1-153c-c6e6-3bc221209bec@ideasonboard.com> (raw)
In-Reply-To: <20221107124814.19b12473@booty>
On 07/11/2022 13:48, Luca Ceresoli wrote:
>> In fact, I'm thinking that it might be better to just drop the i2c-atr
>> driver, and add the support directly to the FPDlink drivers. But that
>> could mean possibly duplicating the same code for other deser/ser
>> architectures, so I have kept the i2c-atr driver for now.
>
> Indeed I think the ROHM serdes chips do have an address translation
> feature that works pretty much like the TI ones, and the ATR should be
> cleanly reusable across the two brands. The ATR code might be
> simplified to just provide helpers for common code maybe, but I'd
> rather avoid code duplication.
I agree. The reason I'm wondering about this is the fact that the i2c
slave side (deser) is in a different IC and driver than the i2c master
side and driver (ser). That makes it quite different from the i2c-mux
(at least how the i2c-mux exists now).
Tomi
next prev parent reply other threads:[~2022-11-07 12:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 13:20 Tomi Valkeinen
2022-11-01 13:20 ` [PATCH v4 1/8] i2c: core: let adapters be notified of client attach/detach Tomi Valkeinen
2022-11-01 13:20 ` [PATCH v4 2/8] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2022-11-01 14:30 ` Andy Shevchenko
2022-11-04 11:59 ` Tomi Valkeinen
2022-11-04 12:38 ` Andy Shevchenko
2022-11-04 15:26 ` Tomi Valkeinen
2022-11-04 17:27 ` Andy Shevchenko
2022-11-07 11:40 ` Luca Ceresoli
2022-12-08 7:56 ` Tomi Valkeinen
2022-11-01 13:20 ` [PATCH v4 3/8] dt-bindings: media: add bindings for TI DS90UB960 Tomi Valkeinen
2022-11-01 16:47 ` Rob Herring
2022-11-02 17:26 ` Rob Herring
2022-11-03 11:50 ` Tomi Valkeinen
2022-11-03 12:13 ` Vaittinen, Matti
2022-11-03 12:32 ` Tomi Valkeinen
2022-11-11 16:26 ` Luca Ceresoli
2022-12-08 9:23 ` Tomi Valkeinen
2022-11-11 16:32 ` Luca Ceresoli
2022-11-11 16:35 ` Luca Ceresoli
2022-11-01 13:20 ` [PATCH v4 4/8] dt-bindings: media: add bindings for TI DS90UB913 Tomi Valkeinen
2022-11-01 16:47 ` Rob Herring
2022-11-02 17:27 ` Rob Herring
2022-11-01 13:20 ` [PATCH v4 5/8] dt-bindings: media: add bindings for TI DS90UB953 Tomi Valkeinen
2022-11-01 16:47 ` Rob Herring
2022-11-01 13:20 ` [PATCH v4 6/8] media: i2c: add DS90UB960 driver Tomi Valkeinen
2022-11-02 8:05 ` Tomi Valkeinen
2022-11-01 13:20 ` [PATCH v4 7/8] media: i2c: add DS90UB913 driver Tomi Valkeinen
2022-11-01 13:20 ` [PATCH v4 8/8] media: i2c: add DS90UB953 driver Tomi Valkeinen
2022-11-07 11:48 ` [PATCH v4 0/8] i2c-atr and FPDLink Luca Ceresoli
2022-11-07 12:12 ` Vaittinen, Matti
2022-11-07 12:12 ` Tomi Valkeinen [this message]
2022-11-07 14:37 ` Vaittinen, Matti
2022-11-07 15:37 ` Tomi Valkeinen
2022-11-07 17:47 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=228da3c5-44b1-153c-c6e6-3bc221209bec@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=luca@lucaceresoli.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=satish.nagireddy@getcruise.com \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®